New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comment out the 'unimplemented' find / find next messages #2930

Merged

devoncarew merged 1 commit into main from comment_out_unimplemented

Apr 3, 2024

Member

devoncarew commented Apr 3, 2024

comment out the 'unimplemented' find / find next messages

This does not provide implementations but does address the optics of putting up 'unimplemented' toasts.

I’ve reviewed the contributor guide and applied the relevant portions to this PR.

Contribution guidelines:

See our contributor guide for general expectations for PRs.
Larger or significant changes should be discussed in an issue before creating a PR.
Contributions to our repos should follow the Dart style guide and use dart format.
Most changes should add an entry to the changelog and may need to rev the pubspec package version.
Changes to packages require corresponding tests.

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.


          comment out the 'unimplemented' find / find next messages

dc86892

parlough approved these changes

View reviewed changes

Member

parlough left a comment

Out of sight.

devoncarew merged commit e8fdd4b into main

4 checks passed

devoncarew deleted the comment_out_unimplemented branch

April 3, 2024 17:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment