-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade our mobile UI to polymer 1.0? #444
Comments
@devoncarew I really want to learn polymer 1.0, so I would like to help with this. Is thsi only about updating the bower dependencies, or should the polymerjs wrapper also be updated ? |
There's a lot involved here :)
And the net net for our use of polymer is that we're consuming the polymer JS components directly, and have written light-weight dart wrapper classes around those components. Happy to have you take a look at this! It'll be a bigger chunk of work, and would have to be done in stages in its own branch. I don't think there's any bit that we could land incrementally in master. Happy to take a look at in-progress work if that helps. |
@devoncarew okay, thanks for clearing this up I also see that some methods in polymer.dart are outdated. I think we need to make these changes:
|
If things aren't used we can remove them, or perhaps comment them out w/ a note if they seem like they might be useful in the context of the new polymer. The logic to detect unregistered elements I think only worked on chrome. It probably implicitly depends on having a real shadow dom or something. It's not necessary to move that functionality forward. It's a nice to have, so you know why your page isn't loading at dev time, but not a critical feature. |
This is quite a bit more work than I thought. So many elements have changed.. But a very good exercise to learn polymer ^^ @devoncarew I have first focussed on finding the right elements, and building just a static dom with those elements. Do you mind if I rewrite the code so that we have the dom just made by html in mobile.html (and not in mobile.dart) ? I think that would be a bit easier now, as I already got this static dom build. But I'm not sure if there may be an important reason to not build the dom using html ? |
It's in dart currently in order to keep the app logic in one place (the dart source), instead of it being split up between dart and html. However, sgtm re: re-doing the UI in html. If we redo the UIs (combine the desktop and mobile UIs), we'll probably converge on polymer, and likely choose to build up most of the UI in dart code at that time. But we'll cross that bridge when we come to it. |
Fixed by #452! |
https://elements.polymer-project.org/browse?package=iron-elements
https://elements.polymer-project.org/browse?package=paper-elements
bower dependencies should be updated to:
The text was updated successfully, but these errors were encountered: