Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a packageImports fields to the analysis response #2687

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

devoncarew
Copy link
Member

  • add a packageImports fields to the analysis response

We can use this field to help know whether to compile with DDC or dart2js.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew
Copy link
Member Author

I'm going to TBR this so that field is available on the live backends, but please feel free to do a post-merge review.

@devoncarew devoncarew merged commit 4c5b0a7 into main Oct 20, 2023
9 checks passed
@devoncarew devoncarew deleted the add_imports branch October 20, 2023 22:04
@@ -79,6 +80,8 @@ class MyApp extends StatelessWidget {

expect(result, isNotNull);
expect(result.issues, isEmpty);
expect(result.packageImports, isNotEmpty);
Copy link
Member

@mosuem mosuem Oct 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Nit) Why check this when checking for flutter in the next line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, its redundant; the intent was to test that we parsed some imports, and then that we parsed the correct imports, but we could just as well only do the 2nd test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants