Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gstatic URL for canvaskit, to avoid CORS errors #2965

Merged
merged 2 commits into from
May 13, 2024
Merged

Use gstatic URL for canvaskit, to avoid CORS errors #2965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fea4ec
Use gstatic URL for canvaskit, to avoid CORS errors
johnpryan May 13, 2024
5485eb3
remove CORS header configuration
johnpryan May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions pkgs/dartpad_ui/firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,6 @@
}
]
},
{
"source": "/canvaskit/chromium/canvaskit.wasm",
"headers": [
{
"key": "Access-Control-Allow-Origin",
"value": "*"
}
]
},
{
"source": "**",
"headers": [
Expand Down
8 changes: 5 additions & 3 deletions pkgs/dartpad_ui/web/frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,19 @@ function messageHandler(e) {
var obj = e.data;

if (obj.command === 'execute') {
runFlutterApp(obj.js);
runFlutterApp(obj.js, obj.canvasKitBaseUrl);
}
};

function runFlutterApp(compiledScript) {
function runFlutterApp(compiledScript, canvasKitBaseUrl) {
var blob = new Blob([compiledScript], {type: 'text/javascript'});
var url = URL.createObjectURL(blob);
_flutter.loader.loadEntrypoint({
entrypointUrl: url,
onEntrypointLoaded: async function(engineInitializer) {
let appRunner = await engineInitializer.initializeEngine();
let appRunner = await engineInitializer.initializeEngine(
{canvasKitBaseUrl: canvasKitBaseUrl}
);
appRunner.runApp();
}
});
Expand Down