Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gstatic URL for canvaskit, to avoid CORS errors #2965

Merged
merged 2 commits into from
May 13, 2024

Conversation

johnpryan
Copy link
Contributor

Follow up for #2960

This ensures that we are loading from the gstatic CDN. The flutter.js bootstrapping engine seems to use the local web server (probably because we are using DDC to compile) but we should be using the CDN.

This also will likely fix CORS errors happening in Safari and Firefox (#2963)

@johnpryan johnpryan requested a review from devoncarew May 13, 2024 17:55
@johnpryan johnpryan merged commit 20da963 into dart-lang:main May 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants