Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occasional death-by-signal of tool processes only seen since #1851 #1861

Closed
jcollins-g opened this issue Dec 5, 2018 · 3 comments
Closed
Assignees
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures

Comments

@jcollins-g
Copy link
Contributor

Rarely, a tool will die with SIGBUS/SIGABRT generating flutter docs. Need to investigate.

@jcollins-g jcollins-g added P1 A high priority bug; for example, a single project is unusable or has many test failures customer-flutter Issues originating from important to Flutter labels Dec 5, 2018
@jcollins-g jcollins-g changed the title Occasional SIGBUS/SIGABRT of tool processes only seen since #1851 Occasional death-by-signal of tool processes only seen since #1851 Dec 5, 2018
@jcollins-g
Copy link
Contributor Author

An example of a segfaulting tool execution.

flutter-docs: error: tool execution failed: Tool "sample" returned non-zero exit code (-6) when run as "/tmp/flutterQLZKVO/bin/cache/dart-sdk/bin/dart /tmp/dartdoc_snapshot_cache_YCKUHF/snapshot_0 --type=sample" from Directory: '/tmp/flutterQLZKVO/dev/docs'
flutter-docs: Input to sample was:
flutter-docs:
flutter-docs: dart flutter-docs: /// A copper coffee pot, as desired by Ben Turpin. flutter-docs: /// ...documentation... flutter-docs: @Category(<String>['Pots', 'Coffee']) flutter-docs: @Category(<String>['Copper', 'Cookware']) flutter-docs: @DocumentationIcon('https://example.com/images/coffee.png') flutter-docs: @Summary('A proper cup of coffee is made in a proper copper coffee pot.') flutter-docs: class CopperCoffeePot { flutter-docs: // ...code... flutter-docs: } flutter-docs:
flutter-docs: Stderr output was:
flutter-docs:
flutter-docs: ===== CRASH =====
flutter-docs: version=2.1.0-dev.9.4.flutter-f9ebf21297 (Thu Nov 8 23:00:07 2018 +0100) on "linux_x64"
flutter-docs: si_signo=Segmentation fault(11), si_code=128, si_addr=(nil)
flutter-docs: Dumping native stack trace for thread 1658
flutter-docs: Stack dump aborted because InitialRegisterCheck failed.
flutter-docs:
flutter-docs: , from foundation.Category: (file:///tmp/flutterQLZKVO/packages/flutter/lib/src/foundation/annotations.dart:40:7)

@jcollins-g
Copy link
Contributor Author

jcollins-g commented Dec 5, 2018

It looks like despite some precautions taken (the snapshot condition variable) to avoid this, we are somehow launching multiple snapshot generations in parallel. While I can't say for sure this is the cause of the crashes, it's definitely not a good thing.

flutter-docs: parsing /tmp/pubcacheZAKPSY/hosted/pub.dartlang.org/process-3.0.9/lib/src/record_replay/common.dart...
flutter-docs: parsing /tmp/pubcacheZAKPSY/hosted/pub.dartlang.org/process-3.0.9/lib/src/record_replay/constants.dart...
flutter-docs: Tool "sample" starting (#0), run as: /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: from: Directory: '/tmp/flutterHPYPAK/dev/docs'
flutter-docs: Tool "sample" starting (#1), run as: /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: from: Directory: '/tmp/flutterHPYPAK/dev/docs'
flutter-docs: Tool "sample" starting (#2), run as: /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: from: Directory: '/tmp/flutterHPYPAK/dev/docs'
flutter-docs: Tool "sample" (#1 complete, run as /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: Tool "sample" (#0 complete, run as /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: Tool "sample" (#2 complete, run as /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart --snapshot=/tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --snapshot_kind=app-jit /tmp/flutterHPYPAK/dev/snippets/lib/main.dart --type=sample
flutter-docs: Tool "sample" starting (#3), run as: /tmp/flutterHPYPAK/bin/cache/dart-sdk/bin/dart /tmp/dartdoc_snapshot_cache_OEIOAB/snapshot_0 --type=sample
flutter-docs: from: Directory: '/tmp/flutterHPYPAK/dev/docs'

@jcollins-g
Copy link
Contributor Author

#1862 so far looks like it makes this go away -- verified that it eliminates the multiple-snapshotting problem and I've seen no more crashes on travis since doing that.

@jcollins-g jcollins-g self-assigned this Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-flutter Issues originating from important to Flutter P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Development

No branches or pull requests

1 participant