Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Arabic locales #696

Open
triallax opened this issue Aug 9, 2023 · 2 comments
Open

Missing Arabic locales #696

triallax opened this issue Aug 9, 2023 · 2 comments
Labels
missing-locale-data P3 A lower priority bug or feature request package:intl type-enhancement A request for a change that isn't a bug

Comments

@triallax
Copy link

triallax commented Aug 9, 2023

Which locale is missing?
List taken from https://www.localeplanet.com/icu/ar/index.html, which may or may not be comprehensive:

  • Arabic (United Arab Emirates) (ar_AE)
  • Arabic (Bahrain) (ar_BH)
  • Arabic (Djibouti) (ar_DJ)
  • Arabic (Western Sahara) (ar_EH)
  • Arabic (Eritrea) (ar_ER)
  • Arabic (Israel) (ar_IL)
  • Arabic (Iraq) (ar_IQ)
  • Arabic (Jordan) (ar_JO)
  • Arabic (Comoros) (ar_KM)
  • Arabic (Kuwait) (ar_KW)
  • Arabic (Lebanon) (ar_LB)
  • Arabic (Libya) (ar_LY)
  • Arabic (Morocco) (ar_MA)
  • Arabic (Mauritania) (ar_MR)
  • Arabic (Oman) (ar_OM)
  • Arabic (Palestinian Territories) (ar_PS)
  • Arabic (Qatar) (ar_QA)
  • Arabic (Saudi Arabia) (ar_SA)
  • Arabic (Sudan) (ar_SD)
  • Arabic (Somalia) (ar_SO)
  • Arabic (South Sudan) (ar_SS)
  • Arabic (Syria) (ar_SY)
  • Arabic (Chad) (ar_TD)
  • Arabic (Tunisia) (ar_TN)
  • Arabic (Yemen) (ar_YE)

(I know that's a lot, but I thought it's much better than spamming the issue tracker with an issue for each locale)

Which locale have you considered of using instead, but was not sufficient?
There is ar, but it has a deal-breaking issue (#477), and either way is way too broad and does not deal with each locale's peculiarities.

@mosuem
Copy link
Member

mosuem commented Aug 10, 2023

Are these locales all needed by your project? As every locale adds to the size burden of this library, I would like to keep the number of supported locales at a reasonable set. Also, #477 would not be solved by adding new locale variants of arabic.

@triallax
Copy link
Author

Are these locales all needed by your project?

Not at the moment, no (I'm putting the finishing touches on adding i18n support to it).

As every locale adds to the size burden of this library, I would like to keep the number of supported locales at a reasonable set.

I get your point, but I still think these locales should be added. #697 is a reasonable solution to this IMO.

Also, #477 would not be solved by adding new locale variants of arabic.

Most certainly not, and I did not mean to imply so.

@mosuem mosuem added the P3 A lower priority bug or feature request label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
missing-locale-data P3 A lower priority bug or feature request package:intl type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants