-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle StateError for closed serviceClient
In dart-lang/json_rpc_2#52 the `Peer` class was fixed to behave like a `Client` when the connection is closed with outstanding requests. `package:dds` was previously relying on having the futures never complete to send the `serviceDisappeared` code when the client was closed with outstanding requests. Check also for the `StateError` that would result from outstanding requests and translate them to `serviceDisappeared`. Change-Id: I2d3f186d1d52d34082b7adf5bf962e22df74015b Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/158220 Auto-Submit: Nate Bosch <nbosch@google.com> Commit-Queue: Ben Konyi <bkonyi@google.com> Reviewed-by: Ben Konyi <bkonyi@google.com>
- Loading branch information
Showing
3 changed files
with
10 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters