Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patterns] More small fixes. #2675

Merged
merged 2 commits into from
Dec 5, 2022
Merged

[patterns] More small fixes. #2675

merged 2 commits into from
Dec 5, 2022

Conversation

munificent
Copy link
Member

  • Specify exhaustiveness checking of switch elements.
  • Resolve ambiguity with => in switch expression guards.
  • Compile error if map pattern has identical keys.

Fix #2672.
Fix #2657.

@munificent
[patterns] More small fixes.
8c257e9 
- Specify exhaustiveness checking of switch elements.
- Resolve ambiguity with `=>` in switch expression guards.
- Compile error if map pattern has identical keys.

Fix #2672.
Fix #2657.
stereotype441
stereotype441 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@stereotype441 stereotype441 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns about implementation feasibility remain, but I think those can be addressed in follow-up discussions, so lgtm.

@munificent munificent merged commit 0badadd into master Dec 5, 2022
@munificent munificent deleted the patterns-fixes branch December 5, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnniwinther johnniwinther johnniwinther left review comments

@stereotype441 stereotype441 stereotype441 approved these changes

@leafpetersen leafpetersen leafpetersen approved these changes

@lrhn lrhn Awaiting requested review from lrhn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@munificent @stereotype441 @lrhn @leafpetersen @johnniwinther