Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Suggestion] Improvements for use_decorated_box #3344

Open
PawlikMichal25 opened this issue Apr 11, 2022 · 1 comment
Open

[Suggestion] Improvements for use_decorated_box #3344

PawlikMichal25 opened this issue Apr 11, 2022 · 1 comment
Labels
false-positive P3 A lower priority bug or feature request set-none Does not affect any rules in a defined rule set (e.g., core, recommended, flutter) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@PawlikMichal25
Copy link

I think use_decorated_box is a useful lint, but in it's current form it's also a bit misleading, because Container with only decoration is not always equivalent to DecoratedBox with same decoration, as discussed here: flutter/flutter#101631

I would propose updating the lint itself, to highlight only Containers (without border?) that are really equivalent to DecoratedBox
or
at least update the documentation of the lint, to inform developers why their UI is changing when they follow this lint.
@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) false-positive labels Jun 29, 2022
@a14n a14n mentioned this issue Jul 4, 2022
Merged
@srawlins
Copy link
Member

@goderbauer WDYT?

@bwilkerson bwilkerson added P3 A lower priority bug or feature request set-none Does not affect any rules in a defined rule set (e.g., core, recommended, flutter) labels Nov 7, 2022
@PawlikMichal25 PawlikMichal25 mentioned this issue May 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
false-positive P3 A lower priority bug or feature request set-none Does not affect any rules in a defined rule set (e.g., core, recommended, flutter) type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@srawlins @bwilkerson @PawlikMichal25