Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report unnecessary_parenthesis when the parent precedence is equal to the expression precedence. #2676

Merged
merged 1 commit into from May 26, 2021
Merged

Report unnecessary_parenthesis when the parent precedence is equal to the expression precedence. #2676

merged 1 commit into from May 26, 2021

Conversation

scheglov
Copy link
Contributor

@google-cla google-cla bot added the cla: yes label May 26, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 94.033% when pulling f4eee8f on scheglov:unnecessary_parenthesis-equal-precedence into ce5c72d on dart-lang:master.

@scheglov scheglov requested review from pq and bwilkerson May 26, 2021 06:33
@pq
Copy link
Member

pq commented May 26, 2021

I do wonder if this will identify any new issues in Flutter (or the ecosystem) but this seems like a change in the right direction, so let's go for it.

Thanks!

@pq pq merged commit 7d8d01f into dart-lang:master May 26, 2021
@scheglov scheglov deleted the unnecessary_parenthesis-equal-precedence branch May 26, 2021 16:25
scheglov added a commit to scheglov/linter that referenced this pull request May 26, 2021
@scheglov
Revert "Report unnecessary_parenthesis when the parent precedence is …
6806bf4 
…equal to the expression precedence. (dart-lang#2676)"

This reverts commit 7d8d01f.
@a14n a14n mentioned this pull request May 26, 2021
Merged
@a14n
Copy link
Contributor

a14n commented May 26, 2021

flutter/flutter#83433 fixes the new diagnotics.

pq pushed a commit that referenced this pull request May 26, 2021
@scheglov
Revert unnecessary parenthesis equal precedence (#2682)
31674eb 
* Revert "Report unnecessary_parenthesis when the parent precedence is equal to the expression precedence. (#2676)"

This reverts commit 7d8d01f.

* Add a test for a discovered false positive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pq pq pq approved these changes

@bwilkerson bwilkerson bwilkerson approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@scheglov @coveralls @pq @a14n @bwilkerson