Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix lint from an improved unnecessary_parenthesis #83433

Merged
merged 1 commit into from May 27, 2021
Merged

fix lint from an improved unnecessary_parenthesis #83433

merged 1 commit into from May 27, 2021

Conversation

a14n
Copy link
Contributor

@a14n a14n commented May 26, 2021

This PR fixes some additional lints (from an upcoming enhanced unnecessary_parenthesis)

@flutter-dashboard flutter-dashboard bot added framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels May 26, 2021
@google-cla google-cla bot added the cla: yes label May 26, 2021
@a14n a14n mentioned this pull request May 26, 2021
Merged
@a14n a14n requested a review from goderbauer May 26, 2021 19:19
@pq
Copy link
Contributor

pq commented May 26, 2021

Super awesome. There were some false positives so we had to revert (dart-lang/linter@31674eb) but these fixes are definitely good. Thanks for applying them! They'll make the change easier to land once we've fixed it up.

/fyi @scheglov

jonahwilliams
jonahwilliams approved these changes May 27, 2021
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 0ef0f0b into flutter:master May 27, 2021
@a14n a14n deleted the unnecessary_parenthesis_next branch May 28, 2021 06:15
goderbauer
goderbauer reviewed Jun 1, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer left review comments

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@a14n @pq @goderbauer @jonahwilliams @fluttergithubbot