Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaks are ignored #615

Open
sundar-karpura opened this issue Jun 15, 2024 · 5 comments
Open

Line breaks are ignored #615

sundar-karpura opened this issue Jun 15, 2024 · 5 comments

Comments

@sundar-karpura
Copy link

For the issue reported in markdown_quill, the fix may be in this repo. Could you please investigate this? The fix may be in EmptyBlockSyntax.

      @override
      Node? parse(BlockParser parser) {
        parser.encounteredBlankLine = true;
        parser.advance();

        // Don't actually emit anything.
        // return null;
        return Element('br', null);  // this change seems to work for my use case, but I have not tested fully.
      }
@srawlins
Copy link
Member

Thanks for filing an issue, can you please explain here what the issue is which you have encountered, including the steps to reproduce, the expected output, and the actual output?

@sundar-karpura
Copy link
Author

Thanks for filing an issue, can you please explain here what the issue is which you have encountered, including the steps to reproduce, the expected output, and the actual output?

Please check the following associated issue, which includes example for reproducing the issue: TarekkMA/markdown_quill#20

@srawlins
Copy link
Member

Sorry, the summary of that issue doesn't really spell out the issue either. I can't read the whole thread to try and tease out what the issue might be with the markdown package.

@matt3o
Copy link

matt3o commented Oct 29, 2024

I think this is not an issue with the markdown parser, so this can probably be closed. Markdown quill "swallows" new lines in some instances, however, I think it can be tracked down to incorrect conversion in the library itself, see
TarekkMA/markdown_quill#37

@srawlins srawlins added the needs-info Additional information needed from the issue author label Oct 29, 2024
@DGrothe-PhD
Copy link

Markdown itself ignores multiple linebreaks. See TarekkMA/markdown_quill#20 (comment) for example...

@github-actions github-actions bot removed the needs-info Additional information needed from the issue author label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants