Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native_toolchain_c] Add defines to API #61

Closed
dcharkes opened this issue Jun 7, 2023 · 0 comments · Fixed by #120
Closed

[native_toolchain_c] Add defines to API #61

dcharkes opened this issue Jun 7, 2023 · 0 comments · Fixed by #120
Labels
P3 A lower priority bug or feature request package:native_toolchain_c type-enhancement A request for a change that isn't a bug

Comments

@dcharkes
Copy link
Collaborator

dcharkes commented Jun 7, 2023

It's likely users compiling C code would like to set some defines.

These should be passed to the CBuilder constructor or run method.

This would enable package-specific mapping from BuildMode to defines. (#60 currently hardcodes RELEASE=1 and DEBUG=1.)
@dcharkes dcharkes mentioned this issue Jun 7, 2023
Merged
@dcharkes dcharkes added type-enhancement A request for a change that isn't a bug P3 A lower priority bug or feature request labels Jun 8, 2023
@dcharkes dcharkes changed the title [c_compiler] Add defines to API [native_toolchain_c] Add defines to API Jul 13, 2023
@dcharkes dcharkes mentioned this issue Sep 1, 2023
Closed
@blaugold blaugold mentioned this issue Sep 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 A lower priority bug or feature request package:native_toolchain_c type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[native_toolchain_c] Add support for configuring preprocessor macro defines blaugold/native
1 participant
@dcharkes