Discontinue/deprecate/archive this package #30

kevmoo · 2020-02-10T21:45:05Z

Functionality the Dart team cares about seems to have been rolled into https://pub.dev/packages/package_config

14 packages used by Dart team: some published, some internal, etc
17 total users on pub: https://pub.dev/packages?q=dependency%3Apackage_resolver

migrate usages in SDK - dart-lang/sdk@9f1fbd2
migrate usages in other packages
- pub tool (dev dependency) – https://github.com/dart-lang/pub/blob/master/pubspec.yaml
- 5 build packages - Stop using package_resolver dart-lang/build#2640
- dwds: dwds: Migrate package_resolver -> package_config ^1.9.1 dart-lang/webdev#915
- pkg:reflectable - Stop using pkg:package_resolver google/reflectable.dart#205
discontinue package on pub.dev - done! https://pub.dev/packages/package_resolver/
archive this package

CC @jakemac53 @lrhn

The text was updated successfully, but these errors were encountered:

jakemac53 · 2020-02-10T21:50:36Z

Nothing scary looking internally - almost all third_party deps (same ones as are on pub already)

lrhn · 2020-02-11T11:34:52Z

Be aware that the currently published version of package_config is not the one to use. We have modified the API since then, so the version to actually use will probably be 3.0.0. (Unless we need to change more things).

The current version is at the tip of the master branch (dart-lang/package_config@96ea916) and is numbered 3.0.0-dev. It has not been published yet (because publishing 2.0.0 was a mistake, so let's not do that again immediately).

jakemac53 · 2020-02-11T14:49:46Z

Oh ok, can we also look at dart-lang/package_config#59 for 3.x @lrhn .

Fixing that also requires breaking changes.

lrhn · 2020-02-18T13:16:15Z

@jakemac53 Already fixed. The version currently used by the SDK has a package_config_types.dart library which does not depend on dart:io. The package_config.dart library exports that and the dart:io dependent load/save functions.

kevmoo · 2020-03-03T22:34:43Z

So the only Dart code using this is the pub client – and only a dev dependency

Grepping the SDK source

.dart_tool/package_config.json:481:      "name": "package_resolver",
.dart_tool/package_config.json:482:      "rootUri": "../third_party/pkg_tested/package_resolver",
.packages:77:package_resolver:third_party/pkg_tested/package_resolver/lib
DEPS:116:  "package_resolver_tag": "1.0.10",
DEPS:344:  Var("dart_root") + "/third_party/pkg_tested/package_resolver":
DEPS:345:      Var("dart_git") + "package_resolver.git"
DEPS:346:      + "@" + Var("package_resolver_tag"),
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:479:    'package_resolver',
pkg/frontend_server/lib/frontend_server.dart:28:import 'package:package_resolver/package_resolver.dart';
pkg/frontend_server/lib/src/javascript_bundle.dart:13:import 'package:package_resolver/package_resolver.dart';
pkg/frontend_server/pubspec.yaml:16:  package_resolver: ^1.0.0
pkg/frontend_server/test/src/javascript_bundle_test.dart:13:import 'package:package_resolver/package_resolver.dart';
pkg/test_runner/lib/src/testing_servers.dart:9:import 'package:package_resolver/package_resolver.dart';
pkg/test_runner/pubspec.yaml:14:  package_resolver:
pkg/test_runner/pubspec.yaml:15:    path: ../../third_party/pkg_tested/package_resolver
runtime/observatory/.packages:24:package_resolver:../../third_party/pkg_tested/package_resolver/lib
tools/patches/flutter-engine/0299903f3e78ab6eb1d7d5ed1a70a039b3646913.patch:10:   'dart_package_resolver_tag': '1.0.10',
tools/patches/flutter-engine/6e2b3f0326bc15ad938319cbbb151f183d064609.patch:11:   'dart_package_resolver_tag': '1.0.10',

jakemac53 · 2020-03-04T15:58:17Z

https://dart-review.googlesource.com/c/sdk/+/138322 for the frontend_server portion

jakemac53 · 2020-03-04T16:15:39Z

Looks like the test_runner still supports a packageRoot argument - trying to see if it is actually in use though.

Trying out removing support here https://dart-review.googlesource.com/c/sdk/+/138324

We want to deprecate package_resolver and it isn't migrating to the latest package_config format. Bug: dart-archive/package_resolver#30 Change-Id: I657ff16dfbf9fa75493d0975b5efcc7f4162431c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138322 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com>

…_config from package_resolver Not sure what might be relying on this - going to check what the bots think about it :D Bug: dart-archive/package_resolver#30 Change-Id: I283d60d749a3db8a4e02dfdb1889ce56c8630620 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138324 Commit-Queue: Jake Macdonald <jakemac@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>

kevmoo · 2020-03-04T20:30:39Z

Awesome work, @jakemac53

.dart_tool/package_config.json:481:      "name": "package_resolver",
.dart_tool/package_config.json:482:      "rootUri": "../third_party/pkg_tested/package_resolver",
.packages:77:package_resolver:third_party/pkg_tested/package_resolver/lib
DEPS:116:  "package_resolver_tag": "1.0.10",
DEPS:344:  Var("dart_root") + "/third_party/pkg_tested/package_resolver":
DEPS:345:      Var("dart_git") + "package_resolver.git"
DEPS:346:      + "@" + Var("package_resolver_tag"),
pkg/front_end/lib/src/fasta/source/source_library_builder.dart:481:    'package_resolver',
runtime/observatory/.packages:24:package_resolver:../../third_party/pkg_tested/package_resolver/lib

Just need to clean up observatory deps and we can remove it entirely from the SDK?

jakemac53 · 2020-03-04T21:03:52Z

Yep I was just starting to look at that

jakemac53 · 2020-03-04T21:04:46Z

@kevmoo do you know about the fasta optOutPackages list that shows up there? can I safely remove it from that?

jakemac53 · 2020-03-04T21:07:58Z

~~https://dart-review.googlesource.com/c/sdk/+/138385 I went ahead and removed it from that list for now~~ Abandoned as there are still third_party deps which vscode doesn't show for some reason when i search.

jakemac53 · 2020-03-04T21:28:50Z

Looks like we are blocked on pub and dart_style removing their deps on this package, and then rolling in some new versions of a bunch of other deps:

source_map_stack_trace
test
test_core
shelf_packages_handler

kevmoo · 2020-03-04T21:35:49Z

Thanks for tracking this, @jakemac53 !

Bug: dart-archive/package_resolver#30 Change-Id: I42c10dabfb14f082b2facc492dd90c1ecdd1901a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138386 Auto-Submit: Jake Macdonald <jakemac@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>

jakemac53 · 2020-03-04T22:25:54Z

@kevmoo have you already filed any issues for pub/dart_style that you can link here or do we need to create those?

kevmoo · 2020-03-04T22:35:45Z

Have not filed issues on those

…

On Wed, Mar 4, 2020, 14:25 Jacob MacDonald ***@***.***> wrote: @kevmoo <https://github.com/kevmoo> have you already filed any issues for pub/dart_style that you can link here or do we need to create those? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#30>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAEFCXU7A4NR7B7LOFHDE3RF3IPFANCNFSM4KSWEPBQ> .

jakemac53 · 2020-03-04T22:39:07Z

dart_style was a red herring just a transitive dep that shows up in the pubsepc.lock file

So it is really just pub.

…atest Bug: dart-archive/package_resolver#30 Change-Id: I4722630ec1e9e5cab3e6bda38b71e2f22ea9e203 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138400 Commit-Queue: Jake Macdonald <jakemac@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Jake Macdonald <jakemac@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>

jakemac53 · 2020-03-26T21:29:43Z

@kevmoo build/webdev are now migrated off completely

Related to dart-archive/package_resolver#30 Change-Id: Ia97424c4a4d8e6721272e65e1ccd1c40fbcdd3c3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141200 Auto-Submit: Kevin Moore <kevmoo@google.com> Reviewed-by: Jake Macdonald <jakemac@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>

kevmoo · 2020-03-26T22:01:15Z

pkg:reflectable is the last hold-out google/reflectable.dart#205

@mit-mit – do we want to move this to dart-archive org? It has the potential to break folks trying to build old SDKS.

I guess once 2.8 ships, it's less of an issue.

mit-mit · 2020-03-27T11:42:35Z

@mit-mit – do we want to move this to dart-archive org? It has the potential to break folks trying to build old SDKS.

Sorry, how does moving the repo, and marking the package as deprecated on pub.dev, break anyone?

eernstg · 2020-03-27T12:39:30Z

Reflectable has been updated such that there is no dependency on package_resolver. However, pub publish currently crashes (cf. dart-lang/pub#2410), so it cannot be published immediately.

eernstg · 2020-03-27T13:04:00Z

Reflectable 2.2.4 is has now been published.

jakemac53 · 2020-03-27T14:34:37Z

Sorry, how does moving the repo, and marking the package as deprecated on pub.dev, break anyone?

I think because old checkouts of the SDK still have a dependency on it, so gclient sync would probably fail? I am actually not sure though because it pulls from our mirror of the repo not the actual github repo, and I don't have any idea how long that would stay up after this repo is moved.

mit-mit · 2020-03-27T14:47:00Z

It's my understanding that github does redirects, e.g. https://github.com/dart-lang/rpc/ redirects to https://github.com/dart-archive/rpc, so that should work?

jakemac53 · 2020-03-27T15:00:15Z

It's my understanding that github does redirects, e.g. https://github.com/dart-lang/rpc/ redirects to https://github.com/dart-archive/rpc, so that should work?

We don't pull from github though, I don't know how our mirrors work or if they will be impacted. cc @sortie I think would know better

kevmoo · 2020-03-27T16:32:08Z

this is all about the internal clone for the SDK

I guess we can do the archive dance and see if anything breaks. Will do it now!

jakemac53 mentioned this issue Feb 10, 2020

Migrate to the latest package_config #29

Closed

This was referenced Feb 10, 2020

Migrate off of package_resolver and onto package_config 1.9 dart-archive/shelf_packages_handler#10

Closed

Migrate off of package_resolver and onto package_config dart-archive/source_map_stack_trace#10

Closed

kevmoo mentioned this issue Mar 4, 2020

dwds: Migrate package_resolver -> package_config ^1.9.1 dart-lang/webdev#915

Closed

jakemac53 mentioned this issue Mar 4, 2020

Migrate off of package_resolver dart-lang/dart_style#898

Closed

jakemac53 mentioned this issue Mar 4, 2020

Migrate off of package_resolver dart-lang/pub#2351

Closed

kevmoo mentioned this issue Mar 26, 2020

Stop using pkg:package_resolver google/reflectable.dart#205

Closed

kevmoo closed this as completed Mar 27, 2020

This was referenced Jun 18, 2020

pub.dev doesn't list package that is available via pub cmd dart-lang/pub-dev#3728

Closed

package_resolver is now discontinued - sass seems to still depend on it sass/dart-sass#1036

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Discontinue/deprecate/archive this package #30

Discontinue/deprecate/archive this package #30

kevmoo commented Feb 10, 2020 •

edited

Loading

jakemac53 commented Feb 10, 2020 •

edited

Loading

lrhn commented Feb 11, 2020

jakemac53 commented Feb 11, 2020

lrhn commented Feb 18, 2020

kevmoo commented Mar 3, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020 •

edited

Loading

kevmoo commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020 •

edited

Loading

jakemac53 commented Mar 4, 2020 •

edited

Loading

kevmoo commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

kevmoo commented Mar 4, 2020 via email

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 26, 2020

kevmoo commented Mar 26, 2020

mit-mit commented Mar 27, 2020

eernstg commented Mar 27, 2020

eernstg commented Mar 27, 2020

jakemac53 commented Mar 27, 2020

mit-mit commented Mar 27, 2020

jakemac53 commented Mar 27, 2020

kevmoo commented Mar 27, 2020

Discontinue/deprecate/archive this package #30

Discontinue/deprecate/archive this package #30

Comments

kevmoo commented Feb 10, 2020 • edited Loading

jakemac53 commented Feb 10, 2020 • edited Loading

lrhn commented Feb 11, 2020

jakemac53 commented Feb 11, 2020

lrhn commented Feb 18, 2020

kevmoo commented Mar 3, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020 • edited Loading

kevmoo commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 4, 2020 • edited Loading

jakemac53 commented Mar 4, 2020 • edited Loading

kevmoo commented Mar 4, 2020

jakemac53 commented Mar 4, 2020

kevmoo commented Mar 4, 2020 via email

jakemac53 commented Mar 4, 2020

jakemac53 commented Mar 26, 2020

kevmoo commented Mar 26, 2020

mit-mit commented Mar 27, 2020

eernstg commented Mar 27, 2020

eernstg commented Mar 27, 2020

jakemac53 commented Mar 27, 2020

mit-mit commented Mar 27, 2020

jakemac53 commented Mar 27, 2020

kevmoo commented Mar 27, 2020

kevmoo commented Feb 10, 2020 •

edited

Loading

jakemac53 commented Feb 10, 2020 •

edited

Loading

jakemac53 commented Mar 4, 2020 •

edited

Loading

jakemac53 commented Mar 4, 2020 •

edited

Loading

jakemac53 commented Mar 4, 2020 •

edited

Loading