-
Notifications
You must be signed in to change notification settings - Fork 7
Discontinue/deprecate/archive this package #30
Comments
Nothing scary looking internally - almost all third_party deps (same ones as are on pub already) |
Be aware that the currently published version of The current version is at the tip of the master branch (dart-lang/package_config@96ea916) and is numbered 3.0.0-dev. It has not been published yet (because publishing 2.0.0 was a mistake, so let's not do that again immediately). |
Oh ok, can we also look at dart-lang/package_config#59 for 3.x @lrhn . Fixing that also requires breaking changes. |
@jakemac53 Already fixed. The version currently used by the SDK has a |
So the only Dart code using this is the Grepping the SDK source
|
https://dart-review.googlesource.com/c/sdk/+/138322 for the frontend_server portion |
Looks like the test_runner still supports a Trying out removing support here https://dart-review.googlesource.com/c/sdk/+/138324 |
We want to deprecate package_resolver and it isn't migrating to the latest package_config format. Bug: dart-archive/package_resolver#30 Change-Id: I657ff16dfbf9fa75493d0975b5efcc7f4162431c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138322 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com>
…_config from package_resolver Not sure what might be relying on this - going to check what the bots think about it :D Bug: dart-archive/package_resolver#30 Change-Id: I283d60d749a3db8a4e02dfdb1889ce56c8630620 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138324 Commit-Queue: Jake Macdonald <jakemac@google.com> Reviewed-by: Bob Nystrom <rnystrom@google.com>
Awesome work, @jakemac53
Just need to clean up observatory deps and we can remove it entirely from the SDK? |
Yep I was just starting to look at that |
@kevmoo do you know about the |
|
Looks like we are blocked on
|
Thanks for tracking this, @jakemac53 ! |
Bug: dart-archive/package_resolver#30 Change-Id: I42c10dabfb14f082b2facc492dd90c1ecdd1901a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138386 Auto-Submit: Jake Macdonald <jakemac@google.com> Commit-Queue: Jake Macdonald <jakemac@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
@kevmoo have you already filed any issues for pub/dart_style that you can link here or do we need to create those? |
Have not filed issues on those
…On Wed, Mar 4, 2020, 14:25 Jacob MacDonald ***@***.***> wrote:
@kevmoo <https://github.com/kevmoo> have you already filed any issues for
pub/dart_style that you can link here or do we need to create those?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEFCXU7A4NR7B7LOFHDE3RF3IPFANCNFSM4KSWEPBQ>
.
|
dart_style was a red herring just a transitive dep that shows up in the pubsepc.lock file So it is really just pub. |
…atest Bug: dart-archive/package_resolver#30 Change-Id: I4722630ec1e9e5cab3e6bda38b71e2f22ea9e203 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138400 Commit-Queue: Jake Macdonald <jakemac@google.com> Commit-Queue: Nate Bosch <nbosch@google.com> Auto-Submit: Jake Macdonald <jakemac@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
@kevmoo build/webdev are now migrated off completely |
Related to dart-archive/package_resolver#30 Change-Id: Ia97424c4a4d8e6721272e65e1ccd1c40fbcdd3c3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141200 Auto-Submit: Kevin Moore <kevmoo@google.com> Reviewed-by: Jake Macdonald <jakemac@google.com> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
@mit-mit – do we want to move this to I guess once 2.8 ships, it's less of an issue. |
Sorry, how does moving the repo, and marking the package as deprecated on pub.dev, break anyone? |
Reflectable has been updated such that there is no dependency on |
Reflectable 2.2.4 is has now been published. |
I think because old checkouts of the SDK still have a dependency on it, so |
It's my understanding that github does redirects, e.g. https://github.com/dart-lang/rpc/ redirects to https://github.com/dart-archive/rpc, so that should work? |
We don't pull from github though, I don't know how our mirrors work or if they will be impacted. cc @sortie I think would know better |
this is all about the internal clone for the SDK I guess we can do the archive dance and see if anything breaks. Will do it now! |
Functionality the Dart team cares about seems to have been rolled into https://pub.dev/packages/package_config
14 packages used by Dart team: some published, some internal, etc
17 total users on pub: https://pub.dev/packages?q=dependency%3Apackage_resolver
CC @jakemac53 @lrhn
The text was updated successfully, but these errors were encountered: