Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency-check SDK constraint semver issues w/ 3.0 dev builds? #1173

Closed
pq opened this issue Dec 8, 2022 · 4 comments
Closed

dependency-check SDK constraint semver issues w/ 3.0 dev builds? #1173

pq opened this issue Dec 8, 2022 · 4 comments

Comments

@pq
Copy link
Member

pq commented Dec 8, 2022

We run pana on a bot for the linter and just started to see dependency-check failures flagging our SDK upper bound:

   {
    "id": "dependency",
    "title": "Support up-to-date dependencies",
    "grantedPoints": 0,
    "maxPoints": 20,
    "status": "failed",
    "summary": "### [x] 0/10 points: All of the package dependencies are supported in the latest version\n\n<details>\n<summary>\n\nSdk constraint doesn't support current Dart version 3.0.0-0.0.dev. Cannot run `dart pub outdated`.\n</summary>\n\n`pubspec.yaml:12:8`\n\n```\n\n12 │   sdk: '>=2.17.0 <3.0.0'\n   │        ^^^^^^^^^^^^^^^^^\n\n```\n\n</details>\n\n### [x] 0/10 points: Package supports latest stable Dart and Flutter SDKs\n\n<details>\n<summary>\n\nSdk constraint doesn't support current Dart version 3.0.0-0.0.dev.\n</summary>\n\n`pubspec.yaml:12:8`\n\n```\n\n12 │   sdk: '>=2.17.0 <3.0.0'\n   │        ^^^^^^^^^^^^^^^^^\n\n```\n\nTry widening the upper boundary of the constraint.\n</details>"
   },

But that doesn't seem right?

Here's the job:

https://github.com/dart-lang/linter/actions/runs/3651289427/jobs/6168331712#step:5:193

Thanks!

@sigurdm
Copy link
Contributor

sigurdm commented Dec 9, 2022

Thanks for reporting.

We need to implement the logic that <3.0.0 implies <4.0.0 for pana also.

@pq
Copy link
Member Author

pq commented Dec 13, 2022

I think this is now fixed and we can close? Needless to say, thanks!

@sigurdm
Copy link
Contributor

sigurdm commented Dec 16, 2022

Yes - closing

@sigurdm sigurdm closed this as completed Dec 16, 2022
@pq
Copy link
Member Author

pq commented Dec 16, 2022

Great. Again, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants