Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter SDK constraint #1432

Closed
nex3 opened this issue Jul 7, 2016 · 2 comments
Closed

Flutter SDK constraint #1432

nex3 opened this issue Jul 7, 2016 · 2 comments
Labels
type-enhancement A request for a change that isn't a bug
Milestone
Q2 2016

Comments

@nex3
Copy link
Member

nex3 commented Jul 7, 2016

As part of #1431, we need to add support for packages declaring constraints on the Flutter SDK. See this comment for details.
@nex3 nex3 added the type-enhancement A request for a change that isn't a bug label Jul 7, 2016
@nex3 nex3 added this to the Q2 2016 milestone Jul 7, 2016
@nex3 nex3 mentioned this issue Jul 7, 2016
Closed
@nex3
Copy link
Member Author

nex3 commented Jul 14, 2016

My original syntax for this doesn't work; it'll cause older pub versions to fail because they don't expect environment.sdk to be a mapping. We'll need to add a separate key under environment. We could just add environment.flutter:

environment:
  sdk: ">=1.19.0 <2.0.0"
  flutter: "^0.1.2"

This isn't super semantic, since Flutter is also an SDK and the term "environment" is pretty broad, but it's the best option I can see.

We also need to add a validator to ensure that if a flutter SDK exists, the "SDK" constraint has a minimum of whatever version this support first gets released in. Otherwise past SDKs may incorrectly install packages that require Flutter.

This was referenced Jul 19, 2016
Closed
Closed
nex3 added a commit that referenced this issue Jul 21, 2016
@nex3
Refactor version_solver_test.
a1a2470 
This brings these tests in line with others, making them integration
tests that invoke a pub process rather than testing the version solver
APIs directly. This will make it easier to add Flutter support in the
future (see #1431 and #1432).

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//2172523002 .
@nex3 nex3 mentioned this issue Jul 21, 2016
Closed
nex3 added a commit that referenced this issue Jul 22, 2016
@nex3
Add support for Flutter SDK constraints.
9a178f3 
We still need to verify that a Flutter SDK constraint is only
used with an appropriate Dart SDK constraint.

See #1432

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//2165423002 .
@nex3 nex3 closed this as completed in 7d06cb5 Jul 22, 2016
@sethladd
Copy link
Contributor

Thanks!

@nex3 nex3 mentioned this issue Aug 1, 2016
Closed
@tvolkert tvolkert mentioned this issue Jun 14, 2017
Closed
@zoechi zoechi mentioned this issue Dec 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
Q2 2016
Development

No branches or pull requests
2 participants
@nex3 @sethladd