[vm] Switch vm-kernel-precomp-mac-debug-simarm_x64 to vm-kernel-preco…

…mp-linux-debug-simarm_x64. The reason is that we can test Assembly snapshot generation on Linux but not on Mac. We have had several bugs propagate to Flutter end-users due to our lack of testing of AOT Assembly snapshots on ARM (SIMARM_X64 in particular), causing reverts of SDK commits and disrupting the Dart -> Flutter roll. For example, see: - flutter/flutter#40114 - flutter/flutter#41228 Change-Id: Ided8116e8230e58ffd350447b2e1a22676bd0506 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118584 Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Samir Jindel <sjindel@google.com>
dart-lang · Sep 25, 2019 · 1c8e5f0 · 1c8e5f0
1 parent d8ed970
commit 1c8e5f0
Show file tree

Hide file tree

Showing 5 changed files with 86 additions and 87 deletions.
diff --git a/cr-buildbucket.cfg b/cr-buildbucket.cfg
@@ -5341,7 +5341,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-debug-x64"
+      name: "vm-kernel-precomp-linux-debug-simarm_x64"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5354,6 +5354,7 @@ buckets: <
         cipd_version: "refs/heads/master"
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
+        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -5364,7 +5365,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-debug-x64-dev"
+      name: "vm-kernel-precomp-linux-debug-simarm_x64-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5378,6 +5379,7 @@ buckets: <
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
         properties_j: "no_approvals:true"
+        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -5388,7 +5390,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-debug-x64-stable"
+      name: "vm-kernel-precomp-linux-debug-simarm_x64-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5402,6 +5404,7 @@ buckets: <
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
         properties_j: "no_approvals:true"
+        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -5412,7 +5415,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-product-x64"
+      name: "vm-kernel-precomp-linux-debug-x64"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5435,7 +5438,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-product-x64-dev"
+      name: "vm-kernel-precomp-linux-debug-x64-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5459,7 +5462,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-product-x64-stable"
+      name: "vm-kernel-precomp-linux-debug-x64-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5483,7 +5486,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm"
+      name: "vm-kernel-precomp-linux-product-x64"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5506,7 +5509,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm-dev"
+      name: "vm-kernel-precomp-linux-product-x64-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5530,7 +5533,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm-stable"
+      name: "vm-kernel-precomp-linux-product-x64-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5554,7 +5557,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm64"
+      name: "vm-kernel-precomp-linux-release-simarm"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5577,7 +5580,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm64-dev"
+      name: "vm-kernel-precomp-linux-release-simarm-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5601,7 +5604,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm64-stable"
+      name: "vm-kernel-precomp-linux-release-simarm-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5625,7 +5628,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-x64"
+      name: "vm-kernel-precomp-linux-release-simarm64"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5648,7 +5651,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-x64-dev"
+      name: "vm-kernel-precomp-linux-release-simarm64-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5672,7 +5675,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-x64-stable"
+      name: "vm-kernel-precomp-linux-release-simarm64-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -5696,20 +5699,19 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-mac-debug-simarm_x64"
+      name: "vm-kernel-precomp-linux-release-x64"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
       dimensions: "host_class:default"
-      dimensions: "os:Mac"
+      dimensions: "os:Linux"
       dimensions: "pool:luci.dart.try"
       recipe: <
         name: "dart/neo"
         cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
         cipd_version: "refs/heads/master"
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
-        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -5720,12 +5722,12 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-mac-debug-simarm_x64-dev"
+      name: "vm-kernel-precomp-linux-release-x64-dev"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
       dimensions: "host_class:default"
-      dimensions: "os:Mac"
+      dimensions: "os:Linux"
       dimensions: "pool:luci.dart.try"
       recipe: <
         name: "dart/neo"
@@ -5734,7 +5736,6 @@ buckets: <
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
         properties_j: "no_approvals:true"
-        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -5745,12 +5746,12 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-mac-debug-simarm_x64-stable"
+      name: "vm-kernel-precomp-linux-release-x64-stable"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
       dimensions: "host_class:default"
-      dimensions: "os:Mac"
+      dimensions: "os:Linux"
       dimensions: "pool:luci.dart.try"
       recipe: <
         name: "dart/neo"
@@ -5759,7 +5760,6 @@ buckets: <
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
         properties_j: "no_approvals:true"
-        properties_j: "shard_timeout:5400"
       >
       priority: 50
       caches: <
@@ -8571,7 +8571,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-debug-x64-try"
+      name: "vm-kernel-precomp-linux-debug-simarm_x64-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -8584,6 +8584,7 @@ buckets: <
         cipd_version: "refs/heads/master"
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
+        properties_j: "shard_timeout:5400"
       >
       priority: 30
       caches: <
@@ -8594,7 +8595,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-product-x64-try"
+      name: "vm-kernel-precomp-linux-debug-x64-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -8617,7 +8618,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm-try"
+      name: "vm-kernel-precomp-linux-product-x64-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -8640,7 +8641,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-simarm64-try"
+      name: "vm-kernel-precomp-linux-release-simarm-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -8663,7 +8664,7 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-linux-release-x64-try"
+      name: "vm-kernel-precomp-linux-release-simarm64-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
@@ -8686,20 +8687,19 @@ buckets: <
       service_account: "dart-luci-try-builder@dart-ci.iam.gserviceaccount.com"
     >
     builders: <
-      name: "vm-kernel-precomp-mac-debug-simarm_x64-try"
+      name: "vm-kernel-precomp-linux-release-x64-try"
       swarming_host: "chromium-swarm.appspot.com"
       swarming_tags: "vpython:native-python-wrapper"
       dimensions: "cpu:x86-64"
       dimensions: "host_class:default"
-      dimensions: "os:Mac"
+      dimensions: "os:Linux"
       dimensions: "pool:luci.dart.try"
       recipe: <
         name: "dart/neo"
         cipd_package: "infra/recipe_bundles/chromium.googlesource.com/chromium/tools/build"
         cipd_version: "refs/heads/master"
         properties_j: "clobber:\"true\""
         properties_j: "new_workflow_enabled:true"
-        properties_j: "shard_timeout:5400"
       >
       priority: 30
       caches: <

diff --git a/luci-milo.cfg b/luci-milo.cfg
@@ -268,14 +268,14 @@ consoles: <
     short_name: "o"
   >
   builders: <
-    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-debug-simarm_x64"
+    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-linux-debug-simarm_x64"
     category: "vm|kernel-precomp"
-    short_name: "ad"
+    short_name: "adx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm_x64"
     category: "vm|kernel-precomp"
-    short_name: "ar"
+    short_name: "arx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm64"
@@ -935,14 +935,14 @@ consoles: <
     short_name: "o"
   >
   builders: <
-    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-debug-simarm_x64"
+    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-linux-debug-simarm_x64"
     category: "vm|kernel-precomp"
-    short_name: "ad"
+    short_name: "adx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm_x64"
     category: "vm|kernel-precomp"
-    short_name: "ar"
+    short_name: "arx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm64"
@@ -1282,14 +1282,14 @@ consoles: <
     short_name: "o"
   >
   builders: <
-    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-debug-simarm_x64-dev"
+    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-linux-debug-simarm_x64-dev"
     category: "vm|kernel-precomp"
-    short_name: "ad"
+    short_name: "adx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm_x64-dev"
     category: "vm|kernel-precomp"
-    short_name: "ar"
+    short_name: "arx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm64-dev"
@@ -1774,14 +1774,14 @@ consoles: <
     short_name: "o"
   >
   builders: <
-    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-debug-simarm_x64-stable"
+    name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-linux-debug-simarm_x64-stable"
     category: "vm|kernel-precomp"
-    short_name: "ad"
+    short_name: "adx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm_x64-stable"
     category: "vm|kernel-precomp"
-    short_name: "ar"
+    short_name: "arx"
   >
   builders: <
     name: "buildbucket/luci.dart.ci.sandbox/vm-kernel-precomp-mac-release-simarm64-stable"