Skip to content

Commit

Permalink
Fix cascade tests with Fasta.
Browse files Browse the repository at this point in the history
There are still failing cascade tests, but these are because of parsing
differences, not because of problems with the test implementation.

R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2726753003 .
  • Loading branch information
scheglov committed Mar 1, 2017
1 parent d1bfe8b commit 270a690
Showing 1 changed file with 2 additions and 79 deletions.
81 changes: 2 additions & 79 deletions pkg/analyzer/test/generated/parser_fasta_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -426,18 +426,6 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
super.test_parseAwaitExpression();
}

@override
@failingTest
void test_parseCascadeSection_i() {
super.test_parseCascadeSection_i();
}

@override
@failingTest
void test_parseCascadeSection_ia() {
super.test_parseCascadeSection_ia();
}

@override
@failingTest
void test_parseCascadeSection_ia_typeArgumentComments() {
Expand All @@ -450,36 +438,12 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
super.test_parseCascadeSection_ia_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_ii() {
super.test_parseCascadeSection_ii();
}

@override
@failingTest
void test_parseCascadeSection_ii_typeArgumentComments() {
super.test_parseCascadeSection_ii_typeArgumentComments();
}

@override
@failingTest
void test_parseCascadeSection_ii_typeArguments() {
super.test_parseCascadeSection_ii_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_p() {
super.test_parseCascadeSection_p();
}

@override
@failingTest
void test_parseCascadeSection_p_assign() {
super.test_parseCascadeSection_p_assign();
}

@override
@failingTest
void test_parseCascadeSection_p_assign_withCascade() {
Expand All @@ -498,36 +462,12 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
super.test_parseCascadeSection_p_assign_withCascade_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_p_builtIn() {
super.test_parseCascadeSection_p_builtIn();
}

@override
@failingTest
void test_parseCascadeSection_pa() {
super.test_parseCascadeSection_pa();
}

@override
@failingTest
void test_parseCascadeSection_pa_typeArgumentComments() {
super.test_parseCascadeSection_pa_typeArgumentComments();
}

@override
@failingTest
void test_parseCascadeSection_pa_typeArguments() {
super.test_parseCascadeSection_pa_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_paa() {
super.test_parseCascadeSection_paa();
}

@override
@failingTest
void test_parseCascadeSection_paa_typeArgumentComments() {
Expand All @@ -540,12 +480,6 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
super.test_parseCascadeSection_paa_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_paapaa() {
super.test_parseCascadeSection_paapaa();
}

@override
@failingTest
void test_parseCascadeSection_paapaa_typeArgumentComments() {
Expand All @@ -558,24 +492,12 @@ class ExpressionParserTest_Fasta extends FastaParserTestCase
super.test_parseCascadeSection_paapaa_typeArguments();
}

@override
@failingTest
void test_parseCascadeSection_pap() {
super.test_parseCascadeSection_pap();
}

@override
@failingTest
void test_parseCascadeSection_pap_typeArgumentComments() {
super.test_parseCascadeSection_pap_typeArgumentComments();
}

@override
@failingTest
void test_parseCascadeSection_pap_typeArguments() {
super.test_parseCascadeSection_pap_typeArguments();
}

@override
@failingTest
void test_parseConstExpression_instanceCreation() {
Expand Down Expand Up @@ -1043,7 +965,8 @@ class FastaParserTestCase extends Object

@override
Expression parseCascadeSection(String code) {
return _parseExpression('null$code');
var cascadeExpression = _parseExpression('null$code') as CascadeExpression;
return cascadeExpression.cascadeSections.single;
}

@override
Expand Down

0 comments on commit 270a690

Please sign in to comment.