Skip to content

Commit

Permalink
Revert "[vm] Add analyze_snapshot tool for AOT snapshot inspection"
Browse files Browse the repository at this point in the history
This reverts commit 19e5749.

Reason for revert: Multiple configurations failing (#47950)

Original change's description:
> [vm] Add analyze_snapshot tool for AOT snapshot inspection
>
> Current skeleton to allow for instrumentation snapshots that can be
> built alongside Dart compilation artifacts and easily referenced for
> specific versions between Snapshot hash <-> DartSDK <-> Flutter Engine
>
> TEST=runtime/tests/vm/dart/analyze_snapshot_binary_test.dart
>
> Change-Id: Ie3757a265bbf457506c72fb62a625fea7bedcb68
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221087
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Slava Egorov <vegorov@google.com>

TBR=vegorov@google.com,cmevans@google.com

Change-Id: Iaaeeeba04ac3283d2df3db8155389db2b358b60a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224601
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
  • Loading branch information
bkonyi authored and Commit Bot committed Dec 16, 2021
1 parent 1e2c400 commit 3657251
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 1,145 deletions.
10 changes: 0 additions & 10 deletions BUILD.gn
Expand Up @@ -50,16 +50,6 @@ group("runtime") {
"utils/kernel-service:kernel-service",
]

# We do not support AOT on ia32 and should therefore cannot provide native
# snapshot tooling.
if (dart_target_arch != "ia32") {
if (is_product) {
deps += [ "runtime/bin:analyze_snapshot_product" ]
} else {
deps += [ "runtime/bin:analyze_snapshot" ]
}
}

# TODO(bkonyi): this dep causes a segfault on Android XARM_X64 builds.
# See issue #41776.
if (dart_target_arch != "arm") {
Expand Down
3 changes: 0 additions & 3 deletions runtime/BUILD.gn
Expand Up @@ -238,7 +238,6 @@ config("dart_libfuzzer_config") {
source_set("dart_api") {
public_configs = [ ":dart_public_config" ]
sources = [
"include/analyze_snapshot_api.h",
"include/dart_api.h",
"include/dart_api_dl.c",
"include/dart_api_dl.h",
Expand Down Expand Up @@ -286,11 +285,9 @@ library_for_all_configs("libdart") {
public_configs = [ ":dart_public_config" ]
sources = [
"$target_gen_dir/version.cc",
"include/analyze_snapshot_api.h",
"include/dart_api.h",
"include/dart_native_api.h",
"include/dart_tools_api.h",
"vm/analyze_snapshot_api_impl.cc",
"vm/dart_api_impl.cc",
"vm/native_api_impl.cc",
"vm/version.h",
Expand Down
39 changes: 0 additions & 39 deletions runtime/bin/BUILD.gn
Expand Up @@ -880,45 +880,6 @@ dart_executable("dart_precompiled_runtime_product") {
extra_deps += [ ":elf_loader_product" ]
}

dart_executable("analyze_snapshot") {
extra_configs = [ "..:dart_precompiled_runtime_config" ]
extra_deps = [
"..:libdart_precompiled_runtime",
"../platform:libdart_platform_precompiled_runtime",
]

extra_sources = [
"analyze_snapshot.cc",
"builtin.cc",
"loader.cc",
"loader.h",
]

if (dart_runtime_mode == "release") {
extra_deps += [ ":elf_loader_product" ]
} else {
extra_deps += [ ":elf_loader" ]
}
}

dart_executable("analyze_snapshot_product") {
use_product_mode = true
extra_configs = [ "..:dart_precompiled_runtime_config" ]
extra_deps = [
"..:libdart_precompiled_runtime_product",
"../platform:libdart_platform_precompiled_runtime_product",
]

extra_sources = [
"analyze_snapshot.cc",
"builtin.cc",
"loader.cc",
"loader.h",
]

extra_deps += [ ":elf_loader_product" ]
}

executable("process_test") {
sources = [ "process_test.cc" ]
}
Expand Down
249 changes: 0 additions & 249 deletions runtime/bin/analyze_snapshot.cc

This file was deleted.

27 changes: 0 additions & 27 deletions runtime/include/analyze_snapshot_api.h

This file was deleted.

0 comments on commit 3657251

Please sign in to comment.