Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analyze_snapshot_binary_test failing on multiple configurations #47950

Open
bkonyi opened this issue Dec 16, 2021 · 6 comments
Open

analyze_snapshot_binary_test failing on multiple configurations #47950

bkonyi opened this issue Dec 16, 2021 · 6 comments
Assignees
@perks
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@bkonyi
Copy link
Contributor

bkonyi commented Dec 16, 2021

Failing on multiple configurations after its introduction in this CL.

Sample logs:

Reverted the change for now.
@bkonyi bkonyi added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Dec 16, 2021
copybara-service bot pushed a commit that referenced this issue Dec 16, 2021
@bkonyi
Revert "[vm] Add analyze_snapshot tool for AOT snapshot inspection"
3657251 
This reverts commit 19e5749.

Reason for revert: Multiple configurations failing (#47950)

Original change's description:
> [vm] Add analyze_snapshot tool for AOT snapshot inspection
>
> Current skeleton to allow for instrumentation snapshots that can be
> built alongside Dart compilation artifacts and easily referenced for
> specific versions between Snapshot hash <-> DartSDK <-> Flutter Engine
>
> TEST=runtime/tests/vm/dart/analyze_snapshot_binary_test.dart
>
> Change-Id: Ie3757a265bbf457506c72fb62a625fea7bedcb68
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221087
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Slava Egorov <vegorov@google.com>

TBR=vegorov@google.com,cmevans@google.com

Change-Id: Iaaeeeba04ac3283d2df3db8155389db2b358b60a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224601
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
@mraleph
Copy link
Member

mraleph commented Dec 16, 2021

Also broke Flutter build: https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8827670475980738513/+/u/gn_--full-dart-sdk_--no-prebuilt-dart-sdk/stdout

Something to keep in mind when relanding.

@liamappelbe
Copy link
Contributor

The reland broke the vm-fuchsia-release-x64 bot. Logs.

Rolling back again

copybara-service bot pushed a commit that referenced this issue Feb 15, 2022
@liamappelbe
Revert "Reland "[vm] Add analyze_snapshot tool for AOT snapshot inspe…
3a3738c 
…ction""

This reverts commit 8d1eedc.

Reason for revert: Broke the Fuchsia bot: #47950 (comment)

Original change's description:
> Reland "[vm] Add analyze_snapshot tool for AOT snapshot inspection"
>
> This is a reland of 19e5749
>
> TEST=runtime/tests/vm/dart/analyze_snapshot_binary_test.dart
>
> Original change's description:
> > [vm] Add analyze_snapshot tool for AOT snapshot inspection
> >
> > Current skeleton to allow for instrumentation snapshots that can be
> > built alongside Dart compilation artifacts and easily referenced for
> > specific versions between Snapshot hash <-> DartSDK <-> Flutter Engine
> >
> > TEST=runtime/tests/vm/dart/analyze_snapshot_binary_test.dart
> >
> > Change-Id: Ie3757a265bbf457506c72fb62a625fea7bedcb68
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221087
> > Reviewed-by: Slava Egorov <vegorov@google.com>
> > Commit-Queue: Slava Egorov <vegorov@google.com>
>
> Change-Id: Ia1ea0071d30818440ae48484ff6c406236af5a4e
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224526
> Reviewed-by: Slava Egorov <vegorov@google.com>
> Commit-Queue: Slava Egorov <vegorov@google.com>

TBR=vegorov@google.com,cmevans@google.com

Change-Id: I1aa0404fa8af9bd31a5c1efbbe7f60d9da2b5b9d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233160
Reviewed-by: Liam Appelbe <liama@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
@perks
Copy link
Contributor

perks commented Feb 16, 2022

Is there a way to presubmit against all the different builds? Currently testing with dry run + all the luci try jobs that are available but seem to miss these edge cases.

@liamappelbe
Copy link
Contributor

I think Flutter and Fuchsia both have try jobs, so you can manually add them. I don't know any other way.

@liamappelbe liamappelbe mentioned this issue Feb 24, 2022
Closed
@whesse
Copy link
Contributor

whesse commented Mar 10, 2022

The test has been relanded in https://dart-review.googlesource.com/c/sdk/+/234500,
and it is flaky timeout on many configurations, and flaky runtime error on mac and arm.

Flakiness: https://screenshot.googleplex.com/6GwHT45T8PdS7Vu
Current status: https://dart-ci.firebaseapp.com/current_results/#/filter=vm/dart_2/analyze_snapshot_binary_test&showAll

@perks
Copy link
Contributor

perks commented Mar 10, 2022 •
edited
Loading

https://github.com/dart-lang/sdk/blob/main/runtime/tests/vm/vm.status#L331 Should be skippin on mac by design. The other flakiness I am not sure about.

https://dart-review.googlesource.com/c/sdk/+/234500/13 Under patchset 13 checks I ran every tryjob available to me and it passed -- the only changes since then was some code cleanup removal and rebasing but I will double check.

Is it possible this is an infrastructure related error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@perks perks

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mraleph @perks @whesse @liamappelbe @bkonyi