Use Fasta scanner when running analyzer.

R=danrubel@google.com Review-Url: https://codereview.chromium.org/2925823002 .
dart-lang · Jun 6, 2017 · 74b037f · 74b037f
1 parent 0357279
commit 74b037f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/pkg/testing/lib/src/analyze.dart b/pkg/testing/lib/src/analyze.dart
@@ -11,7 +11,7 @@ import 'dart:convert' show LineSplitter, UTF8;
 import 'dart:io'
     show Directory, File, FileSystemEntity, Platform, Process, ProcessResult;
 
-import '../testing.dart' show startDart;
+import '../testing.dart' show dartArguments, startDart;
 
 import 'log.dart' show isVerbose, splitLines;
 
@@ -221,7 +221,12 @@ Future<Null> analyzeUris(
     print("Running dartanalyzer.");
   }
   Stopwatch sw = new Stopwatch()..start();
-  Process process = await startDart(analyzer, const <String>["--batch"]);
+  Process process = await startDart(
+      analyzer,
+      const <String>["--batch"],
+      dartArguments
+        ..remove("-c")
+        ..add("-DuseFastaScanner=true"));
   process.stdin.writeln(arguments.join(" "));
   process.stdin.close();
 

diff --git a/pkg/testing/lib/src/discover.dart b/pkg/testing/lib/src/discover.dart
@@ -16,7 +16,8 @@ final Uri dartSdk = computeDartSdk();
 
 /// Common arguments when running a dart program. Returns a copy that can
 /// safely be modified by caller.
-List<String> get dartArguments => <String>["-c", "--packages=$packageConfig"];
+List<String> get dartArguments =>
+    <String>["-c", "--packages=${packageConfig.toFilePath()}"];
 
 Stream<TestDescription> listTests(List<Uri> testRoots, {Pattern pattern}) {
   StreamController<TestDescription> controller =