Skip to content

Commit

Permalink
Revert "Work-around for missing mixin-application charOffset"
Browse files Browse the repository at this point in the history
This reverts commit 2007487.

Needs status file changes.

TBR=sigmund@google.com

BUG=

Review-Url: https://codereview.chromium.org/2992993002 .
  • Loading branch information
rakudrama committed Aug 3, 2017
1 parent c6a7109 commit 9442c1c
Showing 1 changed file with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,6 @@ class KernelLibraryBuilder
int unresolvedCount = 0;
Map<String, TypeBuilder> freeTypes = <String, TypeBuilder>{};

// TODO(30316): Use correct locations of mixin applications
// (e.g. identifiers for mixed-in classes).
if (charOffset == -1) charOffset = type.charOffset;

if (name == null || type.mixins.length != 1) {
TypeBuilder last = type.mixins.last;

Expand Down Expand Up @@ -423,8 +419,8 @@ class KernelLibraryBuilder
checkArguments(mixin);
supertype = applyMixin(supertype, mixin, signature,
isSyntheticMixinImplementation: true,
typeVariables: new List<TypeVariableBuilder>.from(variables.values),
charOffset: charOffset);
typeVariables:
new List<TypeVariableBuilder>.from(variables.values));
}
KernelNamedTypeBuilder mixin = type.mixins.last;

Expand Down

0 comments on commit 9442c1c

Please sign in to comment.