[deps] remove the dep on package:charcode

Change-Id: I0880f16db5bf62e6e7c91352c2f8e57f66ad7022
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247500
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>

BUILD.gn

@@ -214,7 +214,6 @@ if (is_fuchsia) {
       "pkg/smith",
       "third_party/pkg/args",
       "third_party/pkg/async",
-      "third_party/pkg/charcode",
       "third_party/pkg/collection",
       "third_party/pkg/convert",
       "third_party/pkg/crypto",

DEPS

@@ -85,7 +85,6 @@ vars = {
   "browser-compat-data_tag": "ac8cae697014da1ff7124fba33b0b4245cc6cd1b", # v1.0.22
   "browser_launcher_rev": "f841375ad337381e23d333b6eaaebde3d8266c68",
   "characters_rev": "4b1d4b7737ad47cd2b8105c47e2159174010f29f",
-  "charcode_rev": "84ea427711e24abf3b832923959caa7dd9a8514b",
   "chrome_rev": "19997",
   "cli_util_rev": "b0adbba89442b2ea6fef39c7a82fe79cb31e1168",
   "clock_rev": "f594d86da123015186d5680b0d0e8255c52fc162",
@@ -308,8 +307,6 @@ deps = {
       Var("dart_git") + "browser_launcher.git" + "@" + Var("browser_launcher_rev"),
   Var("dart_root") + "/third_party/pkg/characters":
       Var("dart_git") + "characters.git" + "@" + Var("characters_rev"),
-  Var("dart_root") + "/third_party/pkg/charcode":
-      Var("dart_git") + "charcode.git" + "@" + Var("charcode_rev"),
   Var("dart_root") + "/third_party/pkg/cli_util":
       Var("dart_git") + "cli_util.git" + "@" + Var("cli_util_rev"),
   Var("dart_root") + "/third_party/pkg/clock":

pkg/analysis_server/lib/src/services/completion/filtering/fuzzy_matcher.dart

@@ -72,7 +72,6 @@ class FuzzyMatcher {
       '0000000000000000000000000000000010000000000000112222222222100000'
       '0333333333333333333333333330000002222222222222222222222222200000';
 
-  /// TODO(brianwilkerson) Use package:charcode.
   static final int $a = 'a'.codeUnitAt(0);
   static final int $z = 'z'.codeUnitAt(0);
 

pkg/front_end/lib/src/api_prototype/experimental_flags_generated.dart

@@ -596,9 +596,6 @@ const AllowedExperimentalFlags defaultAllowedExperimentalFlags =
       "characters": {
         ExperimentalFlag.nonNullable,
       },
-      "charcode": {
-        ExperimentalFlag.nonNullable,
-      },
       "clock": {
         ExperimentalFlag.nonNullable,
       },

sdk/lib/_internal/allowed_experiments.json

@@ -27,9 +27,6 @@
     "characters": {
       "experimentSet": "nullSafety"
     },
-    "charcode": {
-      "experimentSet": "nullSafety"
-    },
     "clock": {
       "experimentSet": "nullSafety"
     },