Skip to content

Commit

Permalink
Run dartium buildbot tests under xvfb on linux
Browse files Browse the repository at this point in the history
Previously, the entire builder run was under xvfb, now only the tests are.

R=het@google.com
BUG=

Review URL: https://codereview.chromium.org/2038903002 .
  • Loading branch information
whesse committed Jun 3, 2016
1 parent 1fa0ccf commit fbf301c
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions tools/dartium/buildbot_annotated_steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,12 @@

def RunDartTests(mode, component, suite, arch, checked, test_filter=None,
is_win_ninja=False):
"""Runs the Dart WebKit Layout tests.
"""Runs tests using the Dart test.py or the layout test runner.
"""
cmd = [sys.executable]
cmd = []
if sys.platform.startswith('linux'):
cmd = ['xvfb-run', '-a']
cmd.append(sys.executable)
script = os.path.join(DART_PATH, 'tools', 'dartium', 'test.py')
cmd.append(script)
cmd.append('--buildbot')
Expand Down

0 comments on commit fbf301c

Please sign in to comment.