Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart:dom indexeddb unable to delete single object by key #1855

Closed
sethladd opened this issue Feb 25, 2012 · 7 comments
Closed

dart:dom indexeddb unable to delete single object by key #1855

sethladd opened this issue Feb 25, 2012 · 7 comments
Assignees
Labels
P0

Comments

@sethladd
Copy link
Member

@sethladd sethladd commented Feb 25, 2012

The following Dart code:

dom.IDBRequest removeRequest = objectStore.delete(key);

when compiled with Frog, generates this code:

var removeRequest = objectStore.delete_(key);

and fails with this error:

Uncaught NoSuchMethodException : method not found: 'delete_'

@sethladd
Copy link
Member Author

@sethladd sethladd commented Feb 25, 2012

I fixed the problem by adding:

_IDBRequestJs delete(_IDBKeyJs key) native '''return this.delete(key);''';

to dom_frog.dart

and:

_IDBRequestJs delete(_IDBKeyJs key) native '''return this.delete(key);''';

to IDBObjectStore.dart

though I'm not sure if I had to do both :)

@rakudrama
Copy link
Member

@rakudrama rakudrama commented Feb 25, 2012

Since 'delete_' appears nowhere in the Dart and dart:dom code, this is a Frog compiler bug. Frog should not rename native methods.


Set owner to @kasperl.
Removed Area-UI label.
Added Area-Frog label.

@sethladd
Copy link
Member Author

@sethladd sethladd commented Feb 27, 2012

This is blocking an internal partner. Let us know if you need any additional information or context. Thanks!

@kasperl
Copy link
Contributor

@kasperl kasperl commented Feb 28, 2012

Since this is a blocking issue I'm raising the priority. Will take a look today.


Removed Priority-High label.
Added Priority-Critical, Accepted labels.

@kasperl
Copy link
Contributor

@kasperl kasperl commented Feb 28, 2012

CL out for review: https://chromiumcodereview.appspot.com/9487012.


Added Started label.

@kasperl
Copy link
Contributor

@kasperl kasperl commented Feb 29, 2012

Fix landed in r4742. Let me know if this fixes the problem for you, Seth.


Added Fixed label.

@sethladd
Copy link
Member Author

@sethladd sethladd commented Mar 1, 2012

Confirmed. Thanks a ton!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.