Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dartanalyzer crashes when .packages is invalid UTF8 #24127

Closed
harryterkelsen opened this issue Aug 18, 2015 · 3 comments
Closed

dartanalyzer crashes when .packages is invalid UTF8 #24127

harryterkelsen opened this issue Aug 18, 2015 · 3 comments
Assignees
@harryterkelsen
Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on

Comments

@harryterkelsen
Copy link
Contributor

stdout:

Unable to read package config data from /usr/local/google/home/het/code/dart/sdk/tests/standalone/package/scenarios/invalid/invalid_utf8.packages: FormatException: Not a valid package name (at character 1)
þ
^
@bwilkerson bwilkerson added Type-Defect area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-command Issues with the command-line dartanalyzer tool labels Aug 18, 2015
@pq
Copy link
Member

pq commented Aug 19, 2015

Unlike the dart2js corollary (#24120), this doesn't dump a stack trace and the message seems reasonable enough. @hterkelsen: What's the desired result?

@sethladd sethladd mentioned this issue Aug 19, 2015
Closed
12 tasks
@pq
Copy link
Member

pq commented Aug 20, 2015

Back to @hterkelsen: what's the desired result?

@pq pq assigned harryterkelsen and unassigned pq Aug 20, 2015
@harryterkelsen
Copy link
Contributor Author

Since the analyzer is expected to terminate with a nonzero exit code on these then I think it's OK to mark them as 'Crash' in the status file.

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harryterkelsen harryterkelsen

Labels
analyzer-command Issues with the command-line dartanalyzer tool area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @pq @harryterkelsen @bwilkerson