Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsinterop: js_typed_interop_test/closure fails in checked mode with dart2js #24608

Closed
whesse opened this issue Oct 16, 2015 · 5 comments
Closed

jsinterop: js_typed_interop_test/closure fails in checked mode with dart2js #24608

whesse opened this issue Oct 16, 2015 · 5 comments
Assignees
@jacob314
Labels
P2 A bug or feature request we're likely to work on web-dart2js web-js-interop Issues that impact all js interop
Milestone
1.13

Comments

@whesse
Copy link
Contributor

whesse commented Oct 16, 2015

This fails on all browsers, and is not run on non-browsers. Error is

FAIL
8 ERROR
Expectation: closure call from js .

Test failed: Caught type 'JavaScriptFunction' is not a subtype of type 'Function'
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 3078:17 dart.wrapException
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 3548:15 dart.propertyTypeError
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 3559:9 dart.interceptedTypeCheck
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 16429:18 dart.allowInterop
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 17530:33 main__closure3.dart.main__closure3.call$0
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 19506:35 InternalTestCase.dart.InternalTestCase._testFunction$0
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 19545:25 InternalTestCase_run_closure0.dart.InternalTestCase_run_closure0.call$1
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 6409:18 dart._rootRunUnary
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 8113:137 _CustomZone.dart._CustomZone.runUnary$2
http://127.0.0.1:51234/root_build/generated_compilations/dart2js-checked/tests_html_js_typed_interop_test/test.js 7044:80 _Future__propagateToListeners_handleValueCallback.dart._Future__propagateToListeners_handleValueCallback.call$0
@whesse whesse added Type-Defect web-dart2js web-js-interop Issues that impact all js interop labels Oct 16, 2015
@whesse
Copy link
Contributor Author

whesse commented Oct 16, 2015

Failure is suppressed in html/html.status

whesse added a commit that referenced this issue Oct 16, 2015
@whesse
Update status for failing tests
6a816f2 
BUG=#24608
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1410803002 .
@sigmundch
Copy link
Member

Jacob - I assume you'll be more familiar with this. Could you take a look?

@jacob314
Copy link
Member

Out for review.
https://codereview.chromium.org/1416803002/

@jacob314 jacob314 added this to the 1.13 milestone Oct 20, 2015
@jacob314
Copy link
Member

Fixed. Once the build is green, I'll send out a cherry-pick request for 1.13

@mit-mit mit-mit changed the title js_typed_interop_test/closure fails in checked mode with dart2js jsinterop: js_typed_interop_test/closure fails in checked mode with dart2js Oct 20, 2015
@jacob314 jacob314 mentioned this issue Oct 20, 2015
Closed
@mit-mit
Copy link
Member

mit-mit commented Oct 21, 2015

Closing as Bill merged #24656

@mit-mit mit-mit closed this as completed Oct 21, 2015
whesse added a commit that referenced this issue Oct 23, 2015
@whesse
Update status for failing tests
a8287db 
BUG=#24608
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org/1410803002 .
@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob314 jacob314

Labels
P2 A bug or feature request we're likely to work on web-dart2js web-js-interop Issues that impact all js interop
Projects
None yet
Milestone
1.13
Development

No branches or pull requests
5 participants
@kevmoo @jacob314 @sigmundch @whesse @mit-mit