New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer incorrectly issues "unused" warning on variables being used by ??= #27705

Closed

martin88l opened this issue Oct 31, 2016 · 1 comment

Labels

analyzer-warning area-analyzer P2 type-bug

martin88l commented Oct 31, 2016

The following has an unused warning on the variable _a:
import 'dart:async';
class A {
var _a;

void doSomething() {
_a ??= new Future(() => _a = null);
}
}

However, _a is used with ??= so that we don't create multiple futures doing the same work.

bwilkerson added area-analyzer analyzer-warning P2 type-bug labels

srawlins mentioned this issue

Dartanalyzer unused-variable hint is incorrect #29478

Closed

srawlins mentioned this issue

unused_element is reported for external getter/setter pair #42668

Closed

dart-bot pushed a commit that referenced this issue


          Analyzer: Add unused_element tests for ??= and += existing behavior

2fcdfbb

Bug: #42668 and
Change-Id: Ic6f7b513d8c938be4dc60b9d154e532bad754d58
#27705
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/154420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>

Member

pq commented Sep 24, 2021

This looks fixed to me (maybe in 6c7eeb2?). (I can no longer reproduce.)

pq closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment