Flaky VM service tests (mismatching event timestamps) #28624
Assignees
Labels
area-observatory
area-vm
Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
gardening
Comments
kmillikin
added
area-observatory
area-vm
|
Here's another: service/pause_on_start_and_exit_test |
|
service/pause_on_start_then_step_test |
kmillikin
pushed a commit
that referenced
this issue
Feb 3, 2017
These test have (unexpectedly) different event timestamps. This is issue #28624. BUG= R=dmitryas@google.com Review-Url: https://codereview.chromium.org/2671613007 .
|
I started getting this a lot locally so I investigated a bit. I inserted some more debug printing and got this: The important parts seems to be: where "Adding pauseEvent at 2" is from runtime/vm/isolate.cc, Isolate::PrintJSON, case "else if (message_handler()->is_paused_on_start() || message_handler()->should_pause_on_start())". and Set timestamp to x (from y) is from runtime/vm/service_event.cc, ServiceEvent::ServiceEvent : if ((event_kind == ServiceEvent::kPauseStart) &&
!isolate->message_handler()->is_paused_on_start()) {
// We will pause on start but the message handler lacks a valid
// paused timestamp because we haven't paused yet. Use the current time.
timestamp_ = OS::GetCurrentTimeMillis();
printf("Set timestamp to %ld (from 4)\n", timestamp_);
} else if ((event_kind == ServiceEvent::kPauseStart) ||
(event_kind == ServiceEvent::kPauseExit)) {
timestamp_ = isolate->message_handler()->paused_timestamp();
printf("Set timestamp to %ld (from 3)\n", timestamp_);
} else if (event_kind == ServiceEvent::kResume) {
timestamp_ = isolate->last_resume_timestamp();
printf("Set timestamp to %ld (from 2)\n", timestamp_);
}so at least in this case, the test seems to have started and gone into the "I'm paused state" while the vm haven't actually paused yet ("from 4"). Then the test runs reload, the vm actually has paused ("from 3")... |
|
Just as a note this happens quite often (at least to me) (even when not running from kernel) when run in a loop (for instance running a number of terminals with this loop). E.g. something like I then at least gets something like this quite often: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@turnidge These test have been observed to be flaky (command lines are at the bottom of the dump, I dropped the first part of the dump which seemed uninteresting):
service/pause_on_start_and_exit_test
The text was updated successfully, but these errors were encountered: