Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky pkg/analyzer_plugin/tool/spec/check_all_test #29134

Closed
mkustermann opened this issue Mar 22, 2017 · 8 comments
Closed

Flaky pkg/analyzer_plugin/tool/spec/check_all_test #29134

mkustermann opened this issue Mar 22, 2017 · 8 comments
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. gardening P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@mkustermann
Copy link
Member

The buildbot has flakes of the following form (from this build):

FAILED: none-vm-checked release_x64 pkg/analyzer_plugin/tool/spec/check_all_test
Expected: Pass 
Actual: Fail
CommandOutput[vm]:

stdout:
File: '/b/build/slave/pkg-linux-release-be/build/sdk/pkg/analyzer_plugin/test/integration/support/integration_test_methods.dart' does not have expected contents.
File: '/b/build/slave/pkg-linux-release-be/build/sdk/pkg/analyzer_plugin/test/integration/support/protocol_matchers.dart' does not have expected contents.
Please regenerate using:
  out/ReleaseX64/dart-sdk/bin/dart /b/build/slave/pkg-linux-release-be/build/sdk/pkg/analyzer_plugin/tool/spec/generate_all.dart


Command[vm]: DART_CONFIGURATION=ReleaseX64 out/ReleaseX64/dart-sdk/bin/dart --enable_asserts --enable_type_checks --ignore-unrecognized-flags --packages=/b/build/slave/pkg-linux-release-be/build/sdk/.packages /b/build/slave/pkg-linux-release-be/build/sdk/pkg/analyzer_plugin/tool/spec/check_all_test.dart
Took 0:00:07.385730

Short reproduction command (experimental):
    python tools/test.py -mrelease --checked -t60 --use-sdk pkg/analyzer_plugin/tool/spec/check_all_test

It is not possible for me to reproduce this locally. Running the regeneration command is a NOP on my machine.

I will disable/skip this test for now.

@bwilkerson Would you mind taking a look?
@mkustermann mkustermann added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. gardening labels Mar 22, 2017
mkustermann added a commit that referenced this issue Mar 22, 2017
@mkustermann
Skip flaky analyzer_plugin/tool/spec/check_all_test test
18a0cf2 
BUG=#29134

Review-Url: https://codereview.chromium.org/2765273002 .
@whesse
Copy link
Contributor

whesse commented Mar 22, 2017

Duplicate of #29133 #29133

@bwilkerson bwilkerson added P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Mar 22, 2017
@whesse whesse mentioned this issue Mar 22, 2017
Closed
@bwilkerson
Copy link
Member

@devoncarew I suspect that this is a result of adding formatting to the generation process, though I'm not sure why that would cause problems.

@bwilkerson
Copy link
Member

We need to remember to revert https://codereview.chromium.org/2765273002/ when this is fixed (there won't be a failure).

@bwilkerson
Copy link
Member

We need to also revert https://codereview.chromium.org/2768803002/.

@whesse
Copy link
Contributor

whesse commented Mar 22, 2017

This is why issue 29133 says "Please update the expectations of these tests, and then re-enable them in pkg/pkg.status." in its second sentence. All issues that are listed in lines in the status file should have comments in the issue saying which status files were changed, and need to be reverted when the issue is fixed.

Reopening 29133 because it lists the two other tests that are failing.

@whesse
Copy link
Contributor

whesse commented Mar 22, 2017

Leaving #29133 open and closing #29134 as duplicate

@whesse whesse closed this as completed Mar 22, 2017
@bwilkerson
Copy link
Member

But this issue has more useful information in it!

@bwilkerson bwilkerson reopened this Mar 22, 2017
@stereotype441 stereotype441 added P1 A high priority bug; for example, a single project is unusable or has many test failures and removed P2 A bug or feature request we're likely to work on labels Aug 9, 2017
@bwilkerson bwilkerson removed their assignment Sep 6, 2018
@scheglov scheglov self-assigned this Nov 7, 2018
dart-bot pushed a commit that referenced this issue Nov 7, 2018
@scheglov
Issue 29134. Un-skip analysis_server/analyzer_plugin check_all_test.
493e9d3 
I have no idea if something was fixed, but given that we guessed that
it is caused by formatting, maybe things are changed enough that it
is not flaky anymore.

I will revert, or a gardener can revert, if it is still flaky.

R=brianwilkerson@google.com, paulberry@google.com

Bug: #29134
Change-Id: Ide76d50af921b04ce8cd6b96a0ee43f2a7734911
Reviewed-on: https://dart-review.googlesource.com/c/83321
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov
Copy link
Contributor

scheglov commented Nov 7, 2018

Tentatively close.

@scheglov scheglov closed this as completed Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. gardening P1 A high priority bug; for example, a single project is unusable or has many test failures type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stereotype441 @scheglov @whesse @mkustermann @bwilkerson