Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for editor theme support (+6) #293

Closed
pq opened this issue Nov 1, 2011 · 17 comments
Closed

Request for editor theme support (+6) #293

pq opened this issue Nov 1, 2011 · 17 comments
Assignees
@stevemessick
Labels
type-enhancement A request for a change that isn't a bug
Milestone
M3

Comments

@pq
Copy link
Member

pq commented Nov 1, 2011

(From user submitted feedback):

The ability to theme the editor is essential (Looking at black and purple on white is an eye strain).
@DartBot
Copy link

DartBot commented Nov 1, 2011

This comment was originally written by timwy...@gmail.com

Agreed. The theme shows up as black text on black background for me. The only way to use it is if I change my system theme. There needs to be syntax highlighting options or at least an option between using system or default(white background) theme.

@stevemessick
Copy link
Contributor

Issue #296 has been merged into this issue.

@danrubel
Copy link

Changed the title to: "Request for editor theme support (+1)".

@danrubel
Copy link

[user feedback]
 I have color themes in Eclipse IDE (http://www.eclipsecolorthemes.org/) and, maybe it's just because I'm launching Dart Editor from Eclipse, but it's picking up some of that style. I have black text on a dark gray background.

I imagine someone's working on adding color selection to Preferences, but I think I'll add it too just for the experience. Drag and drop textmate themes would please the Mac folks!

Changed the title to: "Request for editor theme support (+2)".

@clayberg
Copy link

[user feedback]
Now wouldn't it be dreamy to be able to customize the editor a bit more : classic tabs in Eclipse, no window animations

Changed the title to: "Request for editor theme support (+3)".

@danrubel
Copy link

danrubel commented Mar 6, 2012

[user feedback]
i hope it could change the theme of editor...
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 4777

Changed the title to: "Request for editor theme support (+4)".

@DartBot
Copy link

DartBot commented Apr 8, 2012

This comment was originally written by fvitale...@gmail.com

In the meantime I changed my background color from white to light grey/blue simply adding to the file: <DART-INSTALL-DIR>\workspace.metadata.plugins\org.eclipse.core.runtime.settings\org.eclipse.ui.editors.prefs

the lines:
AbstractTextEditor.Color.Background.SystemDefault=false
AbstractTextEditor.Color.Background=208,208,223

@clayberg
Copy link

[user feedback]

Hi, the editor is not eye-friendly huh? I have no option found to change the background color, this "white" blend and stress my eyes, also there was
no way to customize syntax coloring.. it rumored some of us are colorblind..!

Changed the title to: "Request for editor theme support (+5)".

@DartBot
Copy link

DartBot commented May 30, 2012

This comment was originally written by rhys.vd...@gmail.com

I'm having the same problem with DartEditor taking my Eclipse theme (it takes the background color). The changes to ..editors.prefs suggested above have not corrected this.

Does anyone have a fix to either change the background or text to a lighter color? Black on black is hard to read.

@danrubel
Copy link

danrubel commented Jun 1, 2012

Added this to the Later milestone.

@stevemessick
Copy link
Contributor

Issue #1052 has been merged into this issue.

@stevemessick
Copy link
Contributor

It would be neat if there was a 'dark' editor theme :)
////////////////////////////////////////////////////////////////////////////////////
Editor: 9474
OS: Mac OS X - x86_64 (10.7.4)
JVM: 1.6.0_33

SDK installed: true
Dartium installed: true

@stevemessick
Copy link
Contributor

I like this ditor, but I do all my coding on a dark background which is easier on the eyes, some colour options in the editor would be really nice.
////////////////////////////////////////////////////////////////////////////////////
Editor: 11397
OS: Windows 8 - amd64 (6.2)
JVM: 1.7.0_06

SDK installed: true
Dartium installed: true

@stevemessick
Copy link
Contributor

Add some functionality to install eclipse color theme plugin
////////////////////////////////////////////////////////////////////////////////////
Editor: 12440 (2012-09-17)
OS: Mac OS X - x86_64 (10.7.4)
JVM: 1.6.0_35

SDK installed: true
Dartium installed: true

@clayberg
Copy link

It would be helpfull if Types such as num, String, Boolean etc are coloured
within the editor to aim in clarity, Other editors do this.
////////////////////////////////////////////////////////////////////////////////////
Editor: 0.2.3_r14669 (2012-11-07)
OS: Windows 7 - x86 (6.1)
JVM: 1.7.0_07

SDK installed: true
Dartium installed: true

Removed this from the Later milestone.
Added this to the M3 milestone.
Changed the title to: "Request for editor theme support (+6)".

@danrubel
Copy link

Support for themes has been added.

Added Fixed label.

@clayberg
Copy link

Set owner to @stevemessick.

@pq pq added this to the M3 milestone Dec 20, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
@MananKakadiya MananKakadiya mentioned this issue Sep 25, 2018
Closed
dart-bot pushed a commit that referenced this issue Aug 14, 2019
@eernstg
Adjusted Dart.g to contain the grammar updates of language repo PR 293
a580529 
This CL makes several adjustments to the spec_parser grammar Dart.g,
such that the spec_parser can parse the proposed NNBD constructs,
cf. language PR #293.

Change-Id: Ieec00259d73b6037d6a87d5c97cfac40186baef0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101500
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
This was referenced Oct 29, 2020
Open
Closed
Closed
This was referenced Nov 5, 2020
Closed
Open
@mmukagali mmukagali mentioned this issue Dec 2, 2022
Closed
copybara-service bot pushed a commit that referenced this issue Jul 20, 2023
@devoncarew
[deps] rev dartdoc, ecosystem, leak_tracker, markdown, mime, native, …
6fd249d 
…string_scanner, test, test_descriptor, vector_math

Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/06d7288..a04ac3e):
  a04ac3e8  2023-07-19  Sam Rawlins  Format testing and fix static-type-parameter issue (#3465)
  a44ecebc  2023-07-19  Sam Rawlins  Move validation-related tasks to package:args (#3463)
  392812e4  2023-07-17  dependabot[bot]  Bump analyzer from 5.13.0 to 6.0.0 (#3458)
  642e8d8b  2023-07-17  Sam Rawlins  Convert 'p' prefixes to 'path' in test/ (#3462)

ecosystem (https://github.com/dart-lang/ecosystem/compare/2052a4c..27ff3e9):
  27ff3e9  2023-07-19  Moritz  Add debug message (#142)
  02703ce  2023-07-18  Moritz  Split commenting into new workflow (#141)
  a52ac63  2023-07-18  Moritz  Finish renaming `coverage_web` (#140)
  ffa1ecb  2023-07-17  Moritz  Health workflow updates (#134)

leak_tracker (https://github.com/dart-lang/leak_tracker/compare/515612e..098bafc):
  098bafc  2023-07-20  fzyzcjy  Update pubspec.yaml (#75)
  7606fd1  2023-07-19  Polina Cherkasova  Improve performance. (#98)
  e6778b3  2023-07-18  Polina Cherkasova  Explain case when static object causes leaks. (#96)
  cca1d77  2023-07-18  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#86)

markdown (https://github.com/dart-lang/markdown/compare/ee4e1b3..faabb1a):
  faabb1a  2023-07-17  Kevin Moore  Bump pkg:http (dev) dependency (#551)

mime (https://github.com/dart-lang/mime/compare/bdb66bd..799b398):
  799b398  2023-07-18  Kevin Moore  update lints, require Dart 3 (#101)
  d17e3ed  2023-07-18  Kevin Moore  blast_repo fixes (#100)

native (https://github.com/dart-lang/native/compare/7c474e1..2598ac6):
  2598ac6  2023-07-20  Daco Harkes  Package name spacing (#101)
  3d73b4a  2023-07-19  Daco Harkes  [native_assets_builder] Builder `out/` folder (#99)
  6308330  2023-07-19  Daco Harkes  Remove compiled files (#92)

string_scanner (https://github.com/dart-lang/string_scanner/compare/35657e2..413b57a):
  413b57a  2023-07-18  Kevin Moore  Require Dart 3, update lints (#61)
  53690da  2023-07-18  Kevin Moore  blast_repo fixes (#60)

test (https://github.com/dart-lang/test/compare/a92b5bb..37e54e3):
  37e54e32  2023-07-19  Nate Bosch  Handle initial message entirely within conditional (#2067)
  e76bffe8  2023-07-19  Nate Bosch  Expand dom interop to cover more uses (#2066)
  8bc188f7  2023-07-18  Lukas Klingsbo  docs: Fix grammar and typos in Checks readme (#2058)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/54a4c59..36d8617):
  36d8617  2023-07-18  dependabot[bot]  Bump actions/checkout from 3.5.2 to 3.5.3 (#53)

vector_math (https://github.com/google/vector_math.dart/compare/c147038..048777a):
  048777a  2023-07-19  moritzblume  Fix rotation around Y axis (#262)
  47a08ea  2023-07-17  dependabot[bot]  Bump actions/checkout from 3.3.0 to 3.5.2 (#293)

Change-Id: Id8010082c818c995aa7968327f98f347ff45761d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315221
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stevemessick stevemessick

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
M3
Development

No branches or pull requests
6 participants
@kevmoo @pq @danrubel @stevemessick @clayberg @DartBot