-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM crash when adding a double and an object with a toDouble method, in production mode #100
Comments
This comment was originally written by olov.la...@gmail.com I should also add that if toDouble is changed such that it actually returns a double instead of and int: then in production mode the program performs the addition and prints 2.200000, while in checked mode it throws the same error as before (Failed type check: type C is not assignable to type num of other in bootstrap_impl at line 898, column 25). |
The plus-operator on numbers is defined as "operator +(num other)". Since you don't give it a class that implements "num", the behavior is undefined. It just happens that apparently "+" calls "toDouble" on the given argument, and then expects a double. Again: if you violate the assumptions (by not returning a double) the behavior is undefined. Here the vm aborts with an assertion-error. Note: the static checker would have told you that the following line is invalid: I leave this bug open in case the VM guys want to improve the error message. |
Set owner to @iposva-google. |
This comment was originally written by olov.la...@gmail.com I expected an exception to be thrown at worst, not an assertion to be fired. The error message itself isn't a problem as such. I'm surprised by the description of undefined behavior allowing VM abortion. Can you provide more information about this, specifically what constitutes undefined behavior in that case? The C instance not implementing the num interface (expected by operator +) seems like a plain type error to me. |
Fix pending: http://codereview.chromium.org/8273001/ |
You are right. I have to correct myself: assertion-error is not an acceptable behavior; nor is abortion of the VM. |
Fixed in r1917 Set owner to @sgmitrovic. |
This comment was originally written by olov.l...@gmail.com I've verified that it works (r1817 though), thanks. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/4d7dc93..f2bb6e9): f2bb6e92 2022-12-07 Sam Rawlins Bump to 6.1.4 (#3266) fixnum (https://github.com/dart-lang/fixnum/compare/62916f2..e4f5e97): e4f5e97 2022-12-08 Michael Thomsen Change IntegerDivisionByZeroException to UnsupportedError (#100) 3bd726f 2022-12-08 Devon Carew rev the sdk min to 2.19.0-0 (#99) logging (https://github.com/dart-lang/logging/compare/f322480..0373ef8): 0373ef8 2022-12-07 Mushaheed Syed Add a check that throws if a logger name ends with '.' (#123) 6d46d71 2022-12-06 Devon Carew Create no-response.yml (#124) protobuf (https://github.com/dart-lang/protobuf/compare/4f3e328..2706b53): 2706b53 2022-12-07 Mahdi K. Fard Add type to a method parameter (#782) a57c16a 2022-12-07 Mahdi K. Fard Fix a typo (#781) shelf (https://github.com/dart-lang/shelf/compare/1c21047..32e342d): 32e342d 2022-12-08 István Soós Prepare the release of shelf_router_generator (#316) 06e2fe6 2022-12-08 Kevin Moore shelf: drop non-null-safe tests (#317) 98363fd 2022-12-06 Kevin Moore lint: sort pub dependencies ad6af2a 2022-12-06 Kevin Moore shelf_static: move RegExp creation out of every request test (https://github.com/dart-lang/test/compare/4dceb87..73cd754): 73cd7540 2022-12-07 Nate Bosch Record the working directory for VM platform (#1804) e40274a6 2022-12-07 Nate Bosch Restore mono_repo config (#1810) 02d8764e 2022-12-07 Sigurd Meldgaard Use Future for return type in runner `main()`. (#1809) 3d6039b3 2022-12-05 Nate Bosch Merge test selections by path (#1806) webdev (https://github.com/dart-lang/webdev/compare/e39506e..3e2364e): 3e2364e 2022-12-07 Elliott Brooks (she/her) Add the Dart Debugger / Flutter Inspector panels in Chrome DevTools (#1812) c164231 2022-12-07 Elliott Brooks (she/her) Small fix to the extension test (#1811) 4bbb4d0 2022-12-06 Elliott Brooks (she/her) Gracefully handle debugger disconnect events (#1808) d3892cf 2022-12-05 Elliott Brooks (she/her) Refactor puppeteer tests to use `Worker` type (#1809) Change-Id: I42033e849f40f209831cfb344247b24ad7731ff0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/274580 Reviewed-by: Nate Bosch <nbosch@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…ctor, browser_launcher, characters, cli_util, clock, collection, convert, crypto, csslib, dartdoc, ecosystem, ffi, fixnum, glob, html, http, http_multi_server, http_parser, json_rpc_2, leak_tracker, lints, logging, markdown, matcher, mime, mockito, native, package_config, path, pool, protobuf, pub_semver, shelf, source_map_stack_trace, source_maps, source_span, sse, stack_trace, stream_channel, string_scanner, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, typed_data, usage, watcher, web_socket_channel, webdev, yaml Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/a9543c0..da56b18): da56b18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#249) async (https://github.com/dart-lang/async/compare/a506993..b65622a): b65622a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#247) bazel_worker (https://github.com/dart-lang/bazel_worker/compare/f7b714e..c29d162): c29d162 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#77) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e717ad4..fde73cb): fde73cb 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#91) boolean_selector (https://github.com/dart-lang/boolean_selector/compare/3a1c982..303635d): 303635d 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#49) browser_launcher (https://github.com/dart-lang/browser_launcher/compare/40e4315..27ec600): 27ec600 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) dd8df9c 2023-07-05 Devon Carew update formatting for recent lints (#47) characters (https://github.com/dart-lang/characters/compare/3ef8883..ec844db): ec844db 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) cli_util (https://github.com/dart-lang/cli_util/compare/5a49947..9b7ce78): 9b7ce78 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) clock (https://github.com/dart-lang/clock/compare/21caac1..263e508): 263e508 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#54) collection (https://github.com/dart-lang/collection/compare/a37bd51..db343da): db343da 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#295) convert (https://github.com/dart-lang/convert/compare/9a387f0..79ee174): 79ee174 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#84) crypto (https://github.com/dart-lang/crypto/compare/216931a..8b704c6): 8b704c6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#150) csslib (https://github.com/dart-lang/csslib/compare/be2e11e..7e91228): 7e91228 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#187) dartdoc (https://github.com/dart-lang/dartdoc/compare/c2ed703..2522559): 25225596 2023-06-29 Sam Rawlins Migrate some simple tasks to a simple package:args command (#3456) ecosystem (https://github.com/dart-lang/ecosystem/compare/19fa443..b34db4f): b34db4f 2023-07-10 Moritz Allow empty coverage (#128) 5944328 2023-07-04 Moritz Prepare for publish (#127) c0701c9 2023-07-04 dependabot[bot] Bump dart-lang/setup-dart from 1.4.0 to 1.5.0 (#122) 9bf3a10 2023-07-03 Moritz Fix bug by switching `reduce` to `fold` (#126) fdfa528 2023-07-01 dependabot[bot] Bump actions/cache from 3.2.6 to 3.3.1 (#121) 238444c 2023-07-01 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.3 (#123) ca1e1ae 2023-06-30 Moritz Add coverage workflow (#119) cf02b4a 2023-06-30 Lasse R.H. Nielsen Make Changelog class eagerly load and parse file. (#120) ffi (https://github.com/dart-lang/ffi/compare/f582ca0..f01dfca): f01dfca 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#199) fixnum (https://github.com/dart-lang/fixnum/compare/d9b9a2a..00fa120): 00fa120 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#113) glob (https://github.com/dart-lang/glob/compare/109121d..5b24393): 5b24393 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#79) html (https://github.com/dart-lang/html/compare/b3b820b..4060496): 4060496 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#218) 8cb99e4 2023-07-01 Devon Carew address new analysis issues (#219) http (https://github.com/dart-lang/http/compare/d68081f..c148a3a): c148a3a 2023-07-07 Alex James Java http BaseClient implementation (#980) 474999f 2023-07-05 Brian Quinlan Document that the network entitlement is required when running in the macOS sandbox (#979) 98e4112 2023-07-05 Brian Quinlan Fix a bug where ...WebSocketClosed had two different initializer signatures (#981) 9833a20 2023-07-05 Brian Quinlan Support Steam<List<int>> as a provider of request data (#975) d3e78a0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#976) http_multi_server (https://github.com/dart-lang/http_multi_server/compare/a209cd5..aa128cf): aa128cf 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#56) http_parser (https://github.com/dart-lang/http_parser/compare/19466c0..c14fbf6): c14fbf6 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/73467f3..509f71e): 509f71e 2023-07-05 Nate Bosch Fix the example to act as a server (#100) d80cbd0 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/c75b0a7..85bd7fb): 85bd7fb 2023-07-05 Polina Cherkasova - (#87) lints (https://github.com/dart-lang/lints/compare/89f9519..e03dc04): e03dc04 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) logging (https://github.com/dart-lang/logging/compare/f2fe2ac..5214987): 5214987 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#144) markdown (https://github.com/dart-lang/markdown/compare/4674d09..b4bdde2): b4bdde2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#549) matcher (https://github.com/dart-lang/matcher/compare/7e10117..ce8f409): ce8f409 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#225) mime (https://github.com/dart-lang/mime/compare/2444840..bdb66bd): bdb66bd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) mockito (https://github.com/dart-lang/mockito/compare/974226e..451f756): 451f756 2023-07-10 Nate Bosch Add example of mocking callbacks c13496c 2023-07-05 Googler Rollback of "Use `FunctionTypedElement.type` while generating method overrides" 60e619a 2023-07-05 Ilya Yanok Use `FunctionTypedElement.type` while generating method overrides 93b69ef 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#669) a926a63 2023-06-30 Ilya Yanok Add a note on only running codegen on files under `test/` by default 9f40189 2023-06-30 Ilya Yanok Require analyzer 5.12.0 native (https://github.com/dart-lang/native/compare/e12d3e6..de1b0cc): de1b0cc 2023-07-10 Daco Harkes [c_compiler] Pass the correct SDK for iOS simulator builds (#77) 21d7270 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#72) 23a9b62 2023-07-01 dependabot[bot] Bump nttld/setup-ndk (#74) 44073a8 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#75) 6f01604 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#73) package_config (https://github.com/dart-lang/package_config/compare/203de20..be0c441): be0c441 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#138) path (https://github.com/dart-lang/path/compare/592505f..282dd18): 282dd18 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#147) pool (https://github.com/dart-lang/pool/compare/c6b1b2c..7700102): 7700102 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#72) protobuf (https://github.com/dart-lang/protobuf/compare/7bebbc6..a912f76): a912f76 2023-07-04 Ömer Sinan Ağacan Add more message set tests, fix a bug (#859) pub_semver (https://github.com/dart-lang/pub_semver/compare/3930557..028b435): 028b435 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#90) shelf (https://github.com/dart-lang/shelf/compare/ce379aa..bd59ead): bd59ead 2023-07-06 Kevin Moore router_generator: allow latest pkg:analyzer, request Dart 3 (#368) bebc801 2023-07-06 Jonas Finnemann Jensen Fix 244 (#268) 1617efa 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#366) c037bb6 2023-07-02 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#365) 1ae4d4e 2023-07-01 Devon Carew address a new lint (#367) source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/b83af01..16e54fd): 16e54fd 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) source_maps (https://github.com/dart-lang/source_maps/compare/58eef30..97c4833): 97c4833 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#80) source_span (https://github.com/dart-lang/source_span/compare/4dc78fb..37735ae): 37735ae 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#99) sse (https://github.com/dart-lang/sse/compare/bfcbcd7..e241085): e241085 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#85) stack_trace (https://github.com/dart-lang/stack_trace/compare/8b2046e..4ddd86d): 4ddd86d 2023-07-05 Slava Egorov Prepare 1.11.1 release (#137) d3e4c4d 2023-07-04 Slava Egorov Use awaiter-link pragma to guide VM's builtin awaiter stack unwinding (#135) 44aafa3 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#136) stream_channel (https://github.com/dart-lang/stream_channel/compare/34804a1..e54234f): e54234f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#93) string_scanner (https://github.com/dart-lang/string_scanner/compare/6bb314f..35657e2): 35657e2 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#59) term_glyph (https://github.com/dart-lang/term_glyph/compare/4daa34e..423700a): 423700a 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#40) test (https://github.com/dart-lang/test/compare/021667a..3429712): 3429712b 2023-07-06 Nate Bosch Drop usage of window.testRunner (#2059) dc6b8236 2023-06-29 dependabot[bot] Bump actions/checkout from 3.1.0 to 3.5.3 (#2051) b6dc3f8d 2023-06-29 dependabot[bot] Bump dart-lang/setup-dart from 1.3.0 to 1.5.0 (#2052) 5fa2572f 2023-06-29 Jacob MacDonald regenerate mono_repo with the latest (#2055) 56584627 2023-06-29 dependabot[bot] Bump github/codeql-action from 2.3.5 to 2.20.1 (#2053) 050fe2d6 2023-06-29 dependabot[bot] Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (#2054) ba6ccfc2 2023-06-29 Devon Carew config dependabot to send daily PRs for major version bumps (#2050) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/be7ce07..54a4c59): 54a4c59 2023-07-03 Devon Carew update formatting for recent lints (#54) test_process (https://github.com/dart-lang/test_process/compare/5ff2122..b360784): b360784 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#46) test_reflective_loader (https://github.com/dart-lang/test_reflective_loader/compare/40d61b1..0bfaad9): 0bfaad9 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#50) tools (https://github.com/dart-lang/tools/compare/8db0aa1..af38b2b): af38b2b 2023-07-02 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#119) 8b8ccab 2023-07-01 Devon Carew update formatting based on the recent lints (#121) 30b50ff 2023-07-01 dependabot[bot] Bump coverallsapp/github-action from 2.1.2 to 2.2.0 (#118) 74979c1 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#120) typed_data (https://github.com/dart-lang/typed_data/compare/8d29573..a20be90): a20be90 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#69) usage (https://github.com/dart-lang/usage/compare/6ee0908..09bb847): 09bb847 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#196) watcher (https://github.com/dart-lang/watcher/compare/3f17faa..7457413): 7457413 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/7fb82f2..7ae4d0f): 7ae4d0f 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#274) webdev (https://github.com/dart-lang/webdev/compare/8360d50..f0ba743): f0ba7438 2023-07-07 Elliott Brooks Reset webdev to version 3.0.7-wip (#2170) 2fcc1ba9 2023-07-06 Anna Gringauze Add option of running frontend server tests in canary mode (#2169) 632763a5 2023-07-06 Elliott Brooks Prepare webdev for release to 3.0.6 (#2167) fa7b6d44 2023-07-05 dependabot[bot] Bump actions/checkout from 3.5.0 to 3.5.3 (#2163) 2a6a457b 2023-07-05 Devon Carew regenerate from the latest mono_repo (#2165) cbb0d76a 2023-07-05 Anna Gringauze Run instance tests with frontend server (#2160) b672e98a 2023-07-05 Elliott Brooks Reset DWDS after release (#2168) 8ef92d71 2023-07-05 Elliott Brooks Prepare DWDS for release to version 19.0.2 (#2166) 77e5b373 2023-07-05 Elliott Brooks Handle potential `null` value in `setUpChromeConsoleListeners` (#2162) 5081dff0 2023-07-01 dependabot[bot] Bump actions/labeler from 4.0.4 to 4.2.0 (#2164) yaml (https://github.com/dart-lang/yaml/compare/0b9041d..7930148): 7930148 2023-07-01 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#148) Change-Id: I095a2479946e13d8499f1b3a58dc5a82688063f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313020 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
…string_scanner, test, test_descriptor, vector_math Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/06d7288..a04ac3e): a04ac3e8 2023-07-19 Sam Rawlins Format testing and fix static-type-parameter issue (#3465) a44ecebc 2023-07-19 Sam Rawlins Move validation-related tasks to package:args (#3463) 392812e4 2023-07-17 dependabot[bot] Bump analyzer from 5.13.0 to 6.0.0 (#3458) 642e8d8b 2023-07-17 Sam Rawlins Convert 'p' prefixes to 'path' in test/ (#3462) ecosystem (https://github.com/dart-lang/ecosystem/compare/2052a4c..27ff3e9): 27ff3e9 2023-07-19 Moritz Add debug message (#142) 02703ce 2023-07-18 Moritz Split commenting into new workflow (#141) a52ac63 2023-07-18 Moritz Finish renaming `coverage_web` (#140) ffa1ecb 2023-07-17 Moritz Health workflow updates (#134) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/515612e..098bafc): 098bafc 2023-07-20 fzyzcjy Update pubspec.yaml (#75) 7606fd1 2023-07-19 Polina Cherkasova Improve performance. (#98) e6778b3 2023-07-18 Polina Cherkasova Explain case when static object causes leaks. (#96) cca1d77 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#86) markdown (https://github.com/dart-lang/markdown/compare/ee4e1b3..faabb1a): faabb1a 2023-07-17 Kevin Moore Bump pkg:http (dev) dependency (#551) mime (https://github.com/dart-lang/mime/compare/bdb66bd..799b398): 799b398 2023-07-18 Kevin Moore update lints, require Dart 3 (#101) d17e3ed 2023-07-18 Kevin Moore blast_repo fixes (#100) native (https://github.com/dart-lang/native/compare/7c474e1..2598ac6): 2598ac6 2023-07-20 Daco Harkes Package name spacing (#101) 3d73b4a 2023-07-19 Daco Harkes [native_assets_builder] Builder `out/` folder (#99) 6308330 2023-07-19 Daco Harkes Remove compiled files (#92) string_scanner (https://github.com/dart-lang/string_scanner/compare/35657e2..413b57a): 413b57a 2023-07-18 Kevin Moore Require Dart 3, update lints (#61) 53690da 2023-07-18 Kevin Moore blast_repo fixes (#60) test (https://github.com/dart-lang/test/compare/a92b5bb..37e54e3): 37e54e32 2023-07-19 Nate Bosch Handle initial message entirely within conditional (#2067) e76bffe8 2023-07-19 Nate Bosch Expand dom interop to cover more uses (#2066) 8bc188f7 2023-07-18 Lukas Klingsbo docs: Fix grammar and typos in Checks readme (#2058) test_descriptor (https://github.com/dart-lang/test_descriptor/compare/54a4c59..36d8617): 36d8617 2023-07-18 dependabot[bot] Bump actions/checkout from 3.5.2 to 3.5.3 (#53) vector_math (https://github.com/google/vector_math.dart/compare/c147038..048777a): 048777a 2023-07-19 moritzblume Fix rotation around Y axis (#262) 47a08ea 2023-07-17 dependabot[bot] Bump actions/checkout from 3.3.0 to 3.5.2 (#293) Change-Id: Id8010082c818c995aa7968327f98f347ff45761d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315221 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/a32ba3a..adc76e6): adc76e6d 2023-09-06 Parker Lougheed Take advantage of a few Dart 3 features (#3491) leak_tracker (https://github.com/dart-lang/leak_tracker/compare/098bafc..4616c8b): 4616c8b 2023-09-05 Polina Cherkasova Note about OverlayEntry. (#142) fd7d70f 2023-09-01 dependabot[bot] Bump actions/checkout from 3.5.3 to 3.6.0 (#141) c6c1004 2023-09-01 Polina Cherkasova - (#139) 0298e20 2023-08-31 Polina Cherkasova Add a test specific rule. (#138) ea17fa4 2023-08-29 Polina Cherkasova Increase version of leak_tracker_flutter_testing (#136) 8f830d6 2023-08-29 Polina Cherkasova Update pubspec.yaml (#135) 8a54575 2023-08-29 Polina Cherkasova Enable connection to vm service for flutter testing and define matcher for reporting for memory allocations. (#128) 88a19a7 2023-08-28 Polina Cherkasova - (#133) 2070856 2023-08-24 Polina Cherkasova Add instruction to start tracking instances of ChangeNotifier earlier. (#130) eb6113a 2023-08-23 Polina Cherkasova Measure how memory is consumed by a test. (#114) 72264f7 2023-08-22 Polina Cherkasova Fix misspelling. (#131) 87c9e9e 2023-08-16 Polina Cherkasova Add debugging construcstors to LeakTrackingTestConfig, per leak type. (#129) b29547a 2023-08-15 Polina Cherkasova Create visibility for roadmap for leak_tracker. (#124) 23b15b6 2023-08-15 Polina Cherkasova Fix issue of using wrong settings for a phase. (#122) 713f646 2023-08-11 Polina Cherkasova Enable global configuration for leak tracking. (#121) 19b01cf 2023-08-10 Polina Cherkasova Create package leak_tracker_flutter_testing. (#119) 02d0b2f 2023-08-07 Polina Cherkasova Stop failing if object is disposed twice. (#117) 2026379 2023-08-04 Polina Cherkasova Remove not-published versions and increase leak_tracker version. (#116) 9bb71c6 2023-08-04 Polina Cherkasova Stop requiring registration of disposed objects. (#113) 8939456 2023-08-04 Polina Cherkasova Refactor dispatcher. (#115) 6f54f5a 2023-08-01 Polina Cherkasova Start vm service when needed. (#112) b045c5e 2023-08-01 Polina Cherkasova Reorganize leak tracker for better performance. (#106) 127b83c 2023-07-31 Polina Cherkasova Update TROUBLESHOOT.md (#108) 6dabd33 2023-07-31 Polina Cherkasova Simplify and clarify instructions to fix leaks. (#107) c53db68 2023-07-25 Polina Cherkasova Improve code structure. (#103) 10cce1a 2023-07-24 Polina Cherkasova Rename `gcCountBuffer` to `numberOfGcCycles`. (#101) 3a061a4 2023-07-21 Polina Cherkasova Improve doc comments. (#100) 6e3f57c 2023-07-21 Polina Cherkasova Fix and test cover case of customized `gcCountBuffer` (#99) 2152aab 2023-07-21 Polina Cherkasova Add details about hidden leaks. (#97) lints (https://github.com/dart-lang/lints/compare/da44af3..8d5f750): 8d5f750 2023-09-06 Devon Carew move the list of lint rules from the readme to a separate rules.md file (#145) native (https://github.com/dart-lang/native/compare/a2dfedc..387f894): 387f894 2023-09-06 Gabriel Terwesten [native_toolchain_c] Default handling for PIC/PIE compiler flags (#121) 0a4e5f8 2023-09-06 Gabriel Terwesten Add support for defines to `CBuilder` (#120) webdev (https://github.com/dart-lang/webdev/compare/fc876cb..9487a45): 9487a459 2023-09-05 Jacob Bang Update README.md to use `dart pub` instead of `pub` (#2195) 07367779 2023-08-31 Elliott Brooks Pass the package config directly to the load strategy instead of depending on an app entrypoint (#2203) 0044d753 2023-08-24 Jonas Termansen Fix conflicting webdev smoke package names. (#2202) 6183f270 2023-08-23 Elliott Brooks Allow client to specify a way to convert an absolute path into a g3-relative path (#2200) b244b899 2023-08-22 Elliott Brooks Allow client to specify how to find the package config (#2199) Change-Id: Ic00adc68ec01cd0cc6e27be665436de5095d8d07 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/324801 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was originally filed by olov.lassu...@gmail.com
Reduced test-case (run in VM with type-checking disabled):
class C {
toDouble() => 0;
}
main() {
print(2.2 + new C());
}
This is what happens:
~/projects/dart/dart % dart --enable_asserts toDoubleBug.dart
./vm/object.h:2201: error: Handle check failed.
zsh: abort dart --enable_asserts toDoubleBug.dart
What should happen:
Not sure (not crash obviously). Checked mode complains (Failed type check: type C is not assignable to type num of other in bootstrap_impl at line 898, column 25.) but it's not clear to me how toDouble is supposed to be used or not currently.
Stack trace:
0 0x91fb6332 in __kill ()
1 0x91fb5932 in kill$UNIX2003 ()
2 0x9b85ac0c in abort ()
3 0x000d1df1 in dart::DynamicAssertionHelper::Fail (this=0xbfffeaa0, format=0x184348 "%s") at /Users/olov/projects/dart/dart/runtime/vm/assert.cc:39
4 0x000be5f5 in dart::Double::CheckedHandle (raw_ptr=0x0) at object.h:2201
5 0x000bcd2e in dart::DN_HelperDouble_add (arguments=0xbffff1a4) at /Users/olov/projects/dart/dart/runtime/lib/double.cc:26
6 0x000bcf0b in dart::DN_Double_add (args=0xbffff1a4) at /Users/olov/projects/dart/dart/runtime/lib/double.cc:24
7 0x00440162 in ?? ()
8 0x006005fc in ?? ()
9 0x0060042d in ?? ()
10 0x006002c2 in ?? ()
11 0x0060007d in ?? ()
12 0x000f9dfd in dart::DartEntry::InvokeStatic (function=@0xbe4ae8, arguments=@0xbffff368, optional_arguments_names=@0xbe4af0) at /Users/olov/projects/dart/dart/runtime/vm/dart_entry.cc:83
13 0x000ae507 in dart::InvokeStatic (function=@0xbe4ae8, args=@0xbffff368, result=0xbffff378) at /Users/olov/projects/dart/dart/runtime/vm/dart_api_impl.cc:844
14 0x000b012f in Dart_InvokeStatic (library_in=0xbe0410, class_name_in=0xbe0418, function_name_in=0xbe0414, number_of_arguments=0, arguments=0x0) at /Users/olov/projects/dart/dart/runtime/vm/dart_api_impl.cc:958
15 0x00002bfb in main (argc=2, argv=0xbffffac8) at /Users/olov/projects/dart/dart/runtime/bin/main.cc:224
The text was updated successfully, but these errors were encountered: