Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation for dart:html timeout property missing units #29428

Closed
natebosch opened this issue Apr 22, 2017 · 1 comment
Closed

documentation for dart:html timeout property missing units #29428

natebosch opened this issue Apr 22, 2017 · 1 comment
Assignees
@natebosch
Labels
area-documentation Prefer using 'type-documentation' and a specific area label.

Comments

@natebosch
Copy link
Member

Linked MDN document mentions 'milliseconds', we should too.

I found where this is defined in docs.json but I don't know the process to update the relevant .dart files...

Will sync with @alan-knight on Monday to get some help with this.
@natebosch natebosch added the area-documentation Prefer using 'type-documentation' and a specific area label. label Apr 22, 2017
@natebosch natebosch self-assigned this Apr 22, 2017
@natebosch
Copy link
Member Author

Thanks to @srawlins for pointing me to #28414 and go.sh.

Here are the steps I took:

sudo pip install markupsafe
sudo pip install idl_parser
cd tools/dom/scripts
./go.sh

Then:

  • dartfmt back all the files that changed only in formatting
  • git add -p and only add the relevant changes to docs and not the giant deletion mentioning MUST RUN tools/dartium/generate_patches.sh

https://codereview.chromium.org/2832353003/ should at least fix the timeout docs

natebosch added a commit that referenced this issue May 5, 2017
@natebosch
Clarify units for timeout
bbc6507 
This is indicated in the linked MDN doc, but we should not make readers
go looking.

Also fix a typo.

BUG=#29428
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2832353003 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@natebosch natebosch

Labels
area-documentation Prefer using 'type-documentation' and a specific area label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@natebosch