Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: void arrow setters should allow any rhs type #29680

Closed
eernstg opened this issue May 22, 2017 · 3 comments
Closed

dart2js: void arrow setters should allow any rhs type #29680

eernstg opened this issue May 22, 2017 · 3 comments
Labels
web-dart2js

Comments

@eernstg
Copy link
Member

eernstg commented May 22, 2017 •
edited
Loading

This is the dart2js specific issue for #29679. The feature is already supported, so this turned out to be an extension of the test suite only.
@eernstg eernstg added this to the 1.24 milestone May 22, 2017
@eernstg eernstg mentioned this issue May 22, 2017
Closed
4 tasks
@eernstg
Copy link
Member Author

eernstg commented May 22, 2017

Given that this just adds some tests, we could live with a later milestone. But for now I'll try to get it into 1.24.

@dgrove
Copy link
Contributor

dgrove commented May 23, 2017

1.24 is very soon. This doesn't look like a hard requirement, so moving to 1.25.

@dgrove dgrove modified the milestones: 1.25, 1.24 May 23, 2017
eernstg added a commit that referenced this issue May 24, 2017
@eernstg
Included setters in testing of the void => return-any-type feature.
8aef60a 
The older issue #28939 did not
mention setters. They were already covered in the implementation, so
this CL just adds testing for it.

Addresses issue #29680.

R=floitsch@google.com, johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2899683003 .
@eernstg
Copy link
Member Author

eernstg commented May 24, 2017

Landed in 8aef60a, I was just waiting for the tree to be reopened.

@eernstg eernstg closed this as completed May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgrove @eernstg