Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old isolate API #3048

Closed
sigmundch opened this issue May 14, 2012 · 3 comments
Closed

remove old isolate API #3048

sigmundch opened this issue May 14, 2012 · 3 comments
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-isolate

Comments

@sigmundch
Copy link
Member

now that the vm and frog support the new Isolate API, remove the old API based on the Isolate class with heavy/light implementations.

This might require to deprecate some examples (e.g. dartcombat) or find a new API for DOM isolates.

@sigmundch
Copy link
Member Author

Issue #59 has been merged into this issue.

@sethladd
Copy link
Contributor

Any word on this?

@sigmundch
Copy link
Member Author

Mads did this in r10210


cc @madsager.
Added Fixed label.

@sigmundch sigmundch added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Aug 8, 2012
@nex3 nex3 added area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-isolate and removed area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Jun 8, 2015
dart-bot pushed a commit that referenced this issue Aug 10, 2021
Bump pub

```
> git log --format="%C(auto) %h %s" 70b1a4f9229a36bac6340ec7eae2b2068baac96c..9f2ddc02f066c68fb638ff65fbb73761ece23267
 9f2ddc02 Use uris for paths in git source descriptions (#3063)
 97a0033e Update README.md (#3069)
 2ef10adf Roll setup-dart (#3054)
 4b5450d3 Updated repository specification. (#3050)
 0f3055db Add executables to allErrors (#3048)
```

Change-Id: Iaa42df2339b6f62aeb63e0f2e7eaf062da84e7c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209681
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot pushed a commit that referenced this issue May 24, 2022
…3 revisions)

https://dart.googlesource.com/dartdoc/+log/c58f21042ebd..8549817bb1b5

2022-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 3 to 3.0.2 (#3048)
2022-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 1.0.26 to 2.1.11 (#3049)
2022-05-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 3.0.0 to 3.1.0 (#3050)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: I14041ce5576cc0efadcc897603f8b7893b891b22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245721
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-isolate
Projects
None yet
Development

No branches or pull requests

3 participants