Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error to spec for use of a final variable in a for-in loop #30489

Closed
bwilkerson opened this issue Aug 18, 2017 · 2 comments
Closed

Add error to spec for use of a final variable in a for-in loop #30489

bwilkerson opened this issue Aug 18, 2017 · 2 comments
Labels
area-specification (deprecated) Deprecated: use area-language and a language- label.

Comments

@bwilkerson
Copy link
Member

The specification should be updated to make it clear that there should be an error if a final variable declared outside the for-in loop is used as the loop variable in a for-in loop.
@bwilkerson bwilkerson added the area-specification (deprecated) Deprecated: use area-language and a language- label. label Aug 18, 2017
@eernstg
Copy link
Member

eernstg commented Aug 18, 2017 •
edited
Loading

This CL addresses assignments to final local variables and also the special case with for-in.

eernstg added a commit that referenced this issue Aug 21, 2017
@eernstg
Added static warning on assignment to final locals; adjusted for-in.
6ef388d 
Addresses spec omission which was brought up in SDK issue #30483.

The following issue was created specifically on this topic: #30489.

R=lrn@google.com

Review-Url: https://codereview.chromium.org/2998073002 .
@eernstg
Copy link
Member

eernstg commented Aug 21, 2017

Addressed by commit 6ef388db.

@eernstg eernstg closed this as completed Aug 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-specification (deprecated) Deprecated: use area-language and a language- label.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwilkerson @eernstg