-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dummy_compiler_test and recursive_import_test are extremely slow on dart2js-linux-d8-hostchecked #30773
Comments
Thanks @athomas To be honest I think it's fine to suppress it in host-checked. These tests were intended as tests of the compiler API, and I'd be fine just testing this in the VM and not running this on any other configuration (so in the dart2js + d8 config seems rather unnecessary). @johnniwinther - do you agree? |
recursive_import_test is not important for CQ nor dart2js+d8. It tests part of the old frontend library loader. dummy_compiler_test doesn't need to be on CQ but should be run on dart2js+d8. It is not interesting on the vm: It is a self-compilation test and we already know that the vm can run dart2js. |
Ok, I will re-enable them for buildbot as soon as we have a way to skip them only for the CQ. |
OK - I sent https://dart-review.googlesource.com/c/sdk/+/45364 to: I think we should eventually move dummy_compiler_test out of dart2js_extra into our actual unit test suite, and similar to our stacktrace tests, we should invoke d8 directly with it instead. |
recursive_import: was covering logic for the old frontend and it is no longer relevant. dummy_compiler is not just about APIs, is about self-hosting. TBR=sra@google.com Bug: #30773 Change-Id: I56d094d9ecee47264c7a7a206f942d9e3dbdaadc Reviewed-on: https://dart-review.googlesource.com/45364 Reviewed-by: Sigmund Cherem <sigmund@google.com> Commit-Queue: Sigmund Cherem <sigmund@google.com>
Skipping the dummy_compiler_test and recursive_import_test reduces the runtime for the dart2js extra tests by 5 minutes (10 minutes total because they are run in checked and unchecked mode) on the dart2js-linux-d8-hostchecked-try builder.
@sigmundch @efortuna I'm adding Skip for that configuration to the status file for now, is there anything that could be done to make these tests execute faster? Is it important to have them in the CQ?
https://dart-review.googlesource.com/c/sdk/+/6400
The text was updated successfully, but these errors were encountered: