Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM: ProfilerDartStackWalker seems confused near the entry frame on Windows #31137

Closed
rmacnak-google opened this issue Oct 18, 2017 · 0 comments
Closed
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@rmacnak-google
Copy link
Contributor

rmacnak-google commented Oct 18, 2017

Sometimes it emits the first Dart frame twice, and sometimes it includes a frame whose claimed pc is the zone zap value.

@rmacnak-google rmacnak-google added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Oct 18, 2017
whesse pushed a commit that referenced this issue Oct 18, 2017
…overflow checks."

Mark some profiler tests on Windows as failing.

Bug: #31137
Change-Id: I46a5d4838443e5cfdac6043ea8dcfeb3d05d4823
Reviewed-on: https://dart-review.googlesource.com/14920
Reviewed-by: Zach Anderson <zra@google.com>
whesse pushed a commit that referenced this issue Oct 18, 2017
Bug: #31137
Change-Id: Ifb742108e2ae9055f4e08ee6261f0dae466d23f5
Reviewed-on: https://dart-review.googlesource.com/15006
Reviewed-by: Ryan Macnak <rmacnak@google.com>
whesse pushed a commit that referenced this issue Oct 19, 2017
Bug: #31137
Change-Id: I68d12c79c092062c0dc91d361744c1b30e715719
Reviewed-on: https://dart-review.googlesource.com/15010
Reviewed-by: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue Nov 5, 2018
Bug: #31137
Bug: #33224
Bug: #33337
Bug: #34493
Change-Id: Iedf6eb71416e50129803f7f9ebd7e2036c7583ef
Reviewed-on: https://dart-review.googlesource.com/c/82528
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

1 participant