Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler_FunctionInline failures #34493

Closed
rmacnak-google opened this issue Sep 17, 2018 · 0 comments
Closed

Profiler_FunctionInline failures #34493

rmacnak-google opened this issue Sep 17, 2018 · 0 comments
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@rmacnak-google
Copy link
Contributor

This has been consistently failing on the Fuchsia mac builder recently. We've seen this fail flakily on the Dart bots in the past too. Might be toolchain related due to inlining of DRT_X functions.

Running test: Profiler_FunctionInline
Done: Profiler_FunctionInline
stderr:
../../runtime/vm/profiler_test.cc: 1573: error: expected: !walker.Down()
../../runtime/vm/profiler_test.cc: 1578: error: expected: <1> but was: <2>
../../runtime/vm/profiler_test.cc: 1579: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1585: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1625: error: expected: !walker.Down()
../../runtime/vm/profiler_test.cc: 1632: error: expected: <1> but was: <2>
../../runtime/vm/profiler_test.cc: 1633: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1639: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1645: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1651: error: expected: <50000> but was: <49999>
../../runtime/vm/profiler_test.cc: 1691: error: expected: !walker.Down()
../../runtime/vm/profiler_test.cc: 1735: error: expected: !walker.Down()
@rmacnak-google rmacnak-google added area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Sep 17, 2018
dart-bot pushed a commit that referenced this issue Sep 17, 2018
@rmacnak-google
[vm] Skip Profiler_FunctionInline on Mac.
1741448 
Bug: #34493
Change-Id: If06ef55201e57f1e5d19de15a94e260b7f09a075
Reviewed-on: https://dart-review.googlesource.com/75202
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue Nov 5, 2018
@rmacnak-google
[vm] Fix profiler tests.
e89aeb0 
Bug: #31137
Bug: #33224
Bug: #33337
Bug: #34493
Change-Id: Iedf6eb71416e50129803f7f9ebd7e2036c7583ef
Reviewed-on: https://dart-review.googlesource.com/c/82528
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google