Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async func closing brace considered hittable by coverage #31222

Closed
cbracken opened this issue Oct 25, 2017 · 1 comment
Closed

Async func closing brace considered hittable by coverage #31222

cbracken opened this issue Oct 25, 2017 · 1 comment
Labels
area-observatory area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@cbracken
Copy link
Member

Copying over from dart-lang/tools#439:

When running coverage on an async function in dart, the closing function brace is always considered a "miss".

From @rmacnak-google:

If I look at an async function in Observatory, I can see there's a synthetic call site at the closing brace for "competeError", and it goes green if I throw inside the function. I'm not sure why this call site shows up when the "complete" one doesn't. I'd consider this a VM bug.
@cbracken cbracken added area-observatory area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Oct 25, 2017
@cbracken
Copy link
Member Author

/cc @rmacnak-google

@cbracken cbracken mentioned this issue Oct 25, 2017
Closed
whesse pushed a commit that referenced this issue Oct 25, 2017
@rmacnak-google
[vm] Mark the synthetic use of completer.completeError in async fun…
2aac007 
…ctions.

Bug: #31222
Change-Id: I4b143ff88b59602f503c7a4d15690a468c577b48
Reviewed-on: https://dart-review.googlesource.com/16605
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
cbracken added a commit to cbracken/coverage that referenced this issue Oct 25, 2017
@cbracken
Test coverage for async function call
0ccc441 
Adds a test to verify expected coverage is generated for an asynchronous
function with two branches, only one of which is executed.

Line 21 is currently marked coverable and not hit due to a VM bug. Once
dart-lang/sdk#31222 is fixed and the new VM
released to stable, we should remove the test expectation for that line
and close https://github.com/dart-lang/coverage/issues/196.
@cbracken cbracken mentioned this issue Oct 25, 2017
Merged
cbracken added a commit to dart-archive/coverage that referenced this issue Oct 25, 2017
@cbracken
Test coverage for async function call (#199)
75f9dae 
Adds a test to verify expected coverage is generated for an asynchronous
function with two branches, only one of which is executed.

Line 21 is currently marked coverable and not hit due to a VM bug. Once
dart-lang/sdk#31222 is fixed and the new VM
released to stable, we should remove the test expectation for that line
and close https://github.com/dart-lang/coverage/issues/196.
cbracken added a commit to cbracken/coverage that referenced this issue Nov 2, 2017
@cbracken
Closing braces on async functions are not coverable
5af6f69 
This eliminates test coverage expectations for the closing brace of
async functions on Dart VMs versioned 2.0 and higher. Due to a bug, the
closing brace of async function blocks was emitted as coverable by the
VM service (it shimmed in completeError as a hidden token on the closing
brace). See: dart-lang/sdk#31222

As of https://dart-review.googlesource.com/c/sdk/+/16605, that issue is
resolved in the VM.
cbracken added a commit to dart-archive/coverage that referenced this issue Nov 2, 2017
@cbracken
Closing braces on async functions are not coverable (#201)
85ae7e7 
This eliminates test coverage expectations for the closing brace of
async functions on Dart VMs versioned 2.0 and higher. Due to a bug, the
closing brace of async function blocks was emitted as coverable by the
VM service (it shimmed in completeError as a hidden token on the closing
brace). See: dart-lang/sdk#31222

As of https://dart-review.googlesource.com/c/sdk/+/16605, that issue is
resolved in the VM.
mosuem pushed a commit to mosuem/tools_fork that referenced this issue Aug 9, 2024
@cbracken
Test coverage for async function call (dart-lang#199)
1bec1be 
Adds a test to verify expected coverage is generated for an asynchronous
function with two branches, only one of which is executed.

Line 21 is currently marked coverable and not hit due to a VM bug. Once
dart-lang/sdk#31222 is fixed and the new VM
released to stable, we should remove the test expectation for that line
and close https://github.com/dart-lang/coverage/issues/196.
mosuem pushed a commit to mosuem/tools_fork that referenced this issue Aug 9, 2024
@cbracken
Closing braces on async functions are not coverable (dart-lang#201)
53a2e1e 
This eliminates test coverage expectations for the closing brace of
async functions on Dart VMs versioned 2.0 and higher. Due to a bug, the
closing brace of async function blocks was emitted as coverable by the
VM service (it shimmed in completeError as a hidden token on the closing
brace). See: dart-lang/sdk#31222

As of https://dart-review.googlesource.com/c/sdk/+/16605, that issue is
resolved in the VM.
mosuem pushed a commit to dart-lang/tools that referenced this issue Aug 28, 2024
@cbracken
Test coverage for async function call (dart-archive/coverage#199)
480b07e 
Adds a test to verify expected coverage is generated for an asynchronous
function with two branches, only one of which is executed.

Line 21 is currently marked coverable and not hit due to a VM bug. Once
dart-lang/sdk#31222 is fixed and the new VM
released to stable, we should remove the test expectation for that line
and close https://github.com/dart-lang/coverage/issues/196.
mosuem pushed a commit to dart-lang/tools that referenced this issue Aug 28, 2024
@cbracken
Closing braces on async functions are not coverable (dart-archive/cov…
c5c9923 
…erage#201)

This eliminates test coverage expectations for the closing brace of
async functions on Dart VMs versioned 2.0 and higher. Due to a bug, the
closing brace of async function blocks was emitted as coverable by the
VM service (it shimmed in completeError as a hidden token on the closing
brace). See: dart-lang/sdk#31222

As of https://dart-review.googlesource.com/c/sdk/+/16605, that issue is
resolved in the VM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-observatory area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbracken @rmacnak-google