Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vm, reload] A member of a mixin should be considered used if it is used in any mixin application #31265

Open
rmacnak-google opened this issue Nov 1, 2017 · 0 comments
Open

[vm, reload] A member of a mixin should be considered used if it is used in any mixin application #31265

rmacnak-google opened this issue Nov 1, 2017 · 0 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload

Comments

@rmacnak-google
Copy link
Contributor

No description provided.

@rmacnak-google rmacnak-google added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload labels Nov 1, 2017
whesse pushed a commit that referenced this issue Nov 2, 2017
@rmacnak-google
[vm, reload] Don't report changes to synthetic classes introduced dur…
7024307 
…ing mixin application.

In particular,

class S {}
class M {}
class MA extends S with M {}

=>

class S {}
class M { newFunction() => 42; }
class MA extends S with M {}

Should not report class S&M nor S&M.newFunction.

Bug: #31265
Change-Id: Iaca4facd68315e1f2921cd2af666608f3e1aa695
Reviewed-on: https://dart-review.googlesource.com/18149
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. vm-hot-reload
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmacnak-google