Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generated prologue code from hand-written assembly to IR #31495

Closed
mkustermann opened this issue Nov 30, 2017 · 1 comment
Closed

Move generated prologue code from hand-written assembly to IR #31495

mkustermann opened this issue Nov 30, 2017 · 1 comment
Assignees
@mkustermann
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@mkustermann
Copy link
Member

No description provided.

@mkustermann mkustermann self-assigned this Nov 30, 2017
whesse pushed a commit that referenced this issue Nov 30, 2017
@mkustermann
[VM] Refactor kernel::FlowGraphBuilder into a re-usable BaseFlowGraph…
23e607a 
…Builder

Issue #31495

Change-Id: I1d85abddb71af91219e0368f0c4d614f40fabe70
Reviewed-on: https://dart-review.googlesource.com/24823
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
@mraleph mraleph added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Nov 30, 2017
whesse pushed a commit that referenced this issue Nov 30, 2017
@mkustermann
[VM] Move removal of unnecessary CheckStackOverflowInstr in leaf func…
ada5985 
…tions

Issue #31495

Change-Id: I0c07cdae00152fc6e2dce10e48b8ba99356e2751
Reviewed-on: https://dart-review.googlesource.com/24780
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
whesse pushed a commit that referenced this issue Nov 30, 2017
@mkustermann
[VM] Make our NativeCallInstr work similar to all other call instruct…
3c0422e 
…ions

This CL makes NativeCallInstr instructions use PushArgument()s when
calling instead of directly using a pointer to the caller-provided
arguments (for functions without optional parameters) or relying on copy
arguments prologue (for functions with optional parameters).

Issue #31495

Change-Id: I36d4bf1b7dd10f48c7e40b0cafe37f8698aacb71
Reviewed-on: https://dart-review.googlesource.com/24961
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
whesse pushed a commit that referenced this issue Dec 1, 2017
@mkustermann
[VM] Add support for skipping a prologue range of blocks (for inlinin…
3347b70 
…g heuristics)

Issue #31495

Change-Id: I876f4e064cfd21f5c3e99b531ff69776eba99635
Reviewed-on: https://dart-review.googlesource.com/25060
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
whesse pushed a commit that referenced this issue Dec 13, 2017
@mkustermann
[VM] Replace hand-written assembly prologues with IR
cf1de7d 
As part of the prologue changes we get rid of the empty context as well.

Issue #31495

Change-Id: I707e23c631bcfbbad6c91c4963d0c10f7a0be625
Reviewed-on: https://dart-review.googlesource.com/25320
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
@mkustermann
Copy link
Member Author

This has been implemented and landed. Closing.

tekknolagi pushed a commit to tekknolagi/dart-assembler that referenced this issue Nov 3, 2020
@mkustermann
[VM] Replace hand-written assembly prologues with IR
6577ff6 
As part of the prologue changes we get rid of the empty context as well.

Issue dart-lang#31495

Change-Id: I707e23c631bcfbbad6c91c4963d0c10f7a0be625
Reviewed-on: https://dart-review.googlesource.com/25320
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkustermann mkustermann

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mraleph @mkustermann