Categorize tests that fail on IE #3304
Assignees
Labels
Comments
|
Removed Priority-Medium label. |
|
Set owner to @kasperl. |
|
I've briefly looked into these failures. Maybe I'm wrong, but it looks like we never ran the samples tests on frog because at least swarm doesn't seem to run correctly on IE (needs applicationCache support). My current theory is that most of the timeouts on the language tests are due us crashing while dealing with thrown exceptions (so the test runner framework never gets the signal that we're done), but I think we've improved this with the recent changes to unwrapException and objectToString. Early next week, I'll run through the tests and try to stop skipping them again. cc @rakudrama. |
|
We now do not skip any tests, but a bunch of tests are still failing. They should be categorized. Removed Priority-High label. |
|
A couple tests marked fail with this bug (lib/view/view_test and lib/layout/layout_test) now pass on IE and Safari after a fix (https://chromiumcodereview.appspot.com/10544076/diff/8001/samples/ui_lib/view/view.dart). swarm_test also runs on Safari. I hit this running the Swarm app itself with Dart2JS on Safari. The fix makes it work. It's surprising to me that Swarm ever ran with Frog on Safari (it did at some point). Perhaps a difference in short circuited &&? |
|
Just fixed 10 IE tests by expanding the NoSuchMethodException detection (IE prints a slightly different error message) https://chromiumcodereview.appspot.com//10882004 |
|
I think we have a good enough grip on the IE failures now. Marking this as fixed (the categorization part). Added Fixed label. |
copybara-service bot
pushed a commit
that referenced
this issue
Mar 29, 2022
Changes: ``` > git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212) https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346) https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361) https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305) https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358) https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215) https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356) https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357) https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359) https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354) https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352) https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349) https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347) https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341) https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340) https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335) https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332) https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331) https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330) https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313) https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320) https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311) https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304) https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297) https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295) https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757) ``` Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/ Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Mar 29, 2022
This reverts commit 6e00bb1. Reason for revert: https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/flutter-engine-linux/16089/overview Original change's description: > Bump pub to 94ae66a660cc187cc46ceaf1ab96bdcf8d48a313 > > Changes: > ``` > > git log --format="%C(auto) %h %s" 8f5ab7b..94ae66a > https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212) > https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346) > https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361) > https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305) > https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358) > https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215) > https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356) > https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357) > https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359) > https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354) > https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352) > https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349) > https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347) > https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341) > https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340) > https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335) > https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332) > https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331) > https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330) > https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313) > https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320) > https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311) > https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304) > https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297) > https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295) > https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757) > > ``` > > Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..94ae66a660cc187cc46ceaf1ab96bdcf8d48a313/ > Change-Id: I121fa281ad77991ef10938a3c228ce1d62e748db > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238901 > Reviewed-by: Jonas Jensen <jonasfj@google.com> > Commit-Queue: Sigurd Meldgaard <sigurdm@google.com> TBR=sigurdm@google.com,jonasfj@google.com Change-Id: I2402e8647ad79a613d8be55a85a7f05f511a4081 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239301 Reviewed-by: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Mar 30, 2022
Changes: ``` > git log --format="%C(auto) %h %s" 8f5ab7b..a3a102a https://dart.googlesource.com/pub.git/+/a3a102a5 Fix equality and hashcode for the sdk descriptors (#3367) https://dart.googlesource.com/pub.git/+/94ae66a6 Refine what a relative uri means in a git path (#3212) https://dart.googlesource.com/pub.git/+/cc4c1292 Only call Package.listFiles once per publish. (#3346) https://dart.googlesource.com/pub.git/+/f4484073 Fix test/global/activate/git_package_test test on windows (#3361) https://dart.googlesource.com/pub.git/+/610ce7f2 Refactor descriptors (#3305) https://dart.googlesource.com/pub.git/+/953b6097 Substitute pub.dartlang.org for of pub.dev (#3358) https://dart.googlesource.com/pub.git/+/7a6ea396 Add support for pubspec overrides file (#3215) https://dart.googlesource.com/pub.git/+/8abfed9d Global activate git path and ref (#3356) https://dart.googlesource.com/pub.git/+/d1c0e3f9 Revert "Add flag controlling creation of `.packages` file. (#2757)" (#3357) https://dart.googlesource.com/pub.git/+/274f5ad9 Fix signals test (#3359) https://dart.googlesource.com/pub.git/+/83437005 Avoid failing in gitignore validator (#3354) https://dart.googlesource.com/pub.git/+/3082796f dependency_services: Don't download archives on apply (#3352) https://dart.googlesource.com/pub.git/+/48d0ffaf dependency_services: Use ^ constraints for widened intervals when possible (#3349) https://dart.googlesource.com/pub.git/+/826e2086 Remove obsolete test (#3347) https://dart.googlesource.com/pub.git/+/35e5140b Bump analyzer from 2.8.0 to 3.3.1 (#3341) https://dart.googlesource.com/pub.git/+/52f2bdc2 Enable dependabot (#3340) https://dart.googlesource.com/pub.git/+/1e70c0c7 Remove `uploader` command (#3335) https://dart.googlesource.com/pub.git/+/3174a264 Warn if git version is not high enough for supporting all features (#3332) https://dart.googlesource.com/pub.git/+/3f7a3cb7 Don't analyze ignored directories in directory-validator (#3331) https://dart.googlesource.com/pub.git/+/e8f36614 Allow use of token for talking to pub.dev (#3330) https://dart.googlesource.com/pub.git/+/b93bf88f Upgrade `package:tar` to version `0.5.4`. (#3313) https://dart.googlesource.com/pub.git/+/fbc9732e Support for different versioning strategies in dependency_services (#3320) https://dart.googlesource.com/pub.git/+/93c7cfcd Update repository-spec-v2.md (#3311) https://dart.googlesource.com/pub.git/+/941191f7 dependency_services (#3304) https://dart.googlesource.com/pub.git/+/61175cb6 fix: relative to the current directory rules (#3297) https://dart.googlesource.com/pub.git/+/f27e90d3 Upgrade other versions conservatively with --major-versions (#3295) https://dart.googlesource.com/pub.git/+/a2461417 Add flag controlling creation of `.packages` file. (#2757) ``` Diff: https://dart.googlesource.com/pub.git/+/8f5ab7b1aba3b9f66b56246d77e167990339d317~..a3a102a549388a6dbfecc9252fabb618f9a2f5f7/ Change-Id: I8d0ea375039ea450d397871d9fac35d590ea8869 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239315 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Jan 17, 2023
…, webdev Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/c4ab682..a99abd4): a99abd4b 2023-01-16 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#3305) a692eeaa 2023-01-16 dependabot[bot] Bump github/codeql-action from 2.1.37 to 2.1.38 (#3304) a43a6c2b 2023-01-14 Parker Lougheed Remove search code debug prints (#3300) cf28572a 2023-01-14 Parker Lougheed Remove obsolete doc_packages tool (#3301) fcbadcd7 2023-01-14 Parker Lougheed Remove null safety badge (#3295) 263ea617 2023-01-14 Parker Lougheed Use spread syntax instead of add (#3296) 820b5ba5 2023-01-14 Parker Lougheed Use equal signs to set default parameter values (#3298) 31e9c797 2023-01-14 Parker Lougheed Fix build by removing test opting out of null safety (#3297) d4495c2c 2023-01-11 dependabot[bot] Bump actions/checkout from 3.2.0 to 3.3.0 (#3292) 3ae8eef5 2023-01-11 dependabot[bot] Bump actions/upload-artifact from 3.1.1 to 3.1.2 (#3291) 8a9e4691 2023-01-11 dependabot[bot] Bump actions/cache from 3.2.2 to 3.2.3 (#3290) http (https://github.com/dart-lang/http/compare/d434d42..c955c7e): c955c7e 2023-01-13 Brian Quinlan Add consistent implementations for `close`. (#851) intl (https://github.com/dart-lang/intl/compare/c61fdd1..6140b60): 6140b60 2023-01-12 Googler Internal change mime (https://github.com/dart-lang/mime/compare/273d454..034471a): 034471a 2023-01-11 Kevin Moore Prepare to release v1.0.4 (#80) string_scanner (https://github.com/dart-lang/string_scanner/compare/c58618d..0454980): 0454980 2023-01-17 Kevin Moore dependabot: monthly is plenty (#54) sync_http (https://github.com/dart-lang/sync_http/compare/8622614..36a1bd0): 36a1bd0 2023-01-11 Kevin Moore Bump min SDK, enable and fix new lints (#34) test (https://github.com/dart-lang/test/compare/932a652..43fd928): 43fd9284 2023-01-17 Jacob MacDonald delete some old integration test helper files that were opted out (#1850) 2c59fb6c 2023-01-17 Kevin Moore Run no response daily (#1849) 8ea50552 2023-01-12 joshualitt Update wasm integration test to use generated JS runtime for Dart2Wasm. (#1844) 9a23b72a 2023-01-11 Nate Bosch Prepare to publish (#1843) d887825a 2023-01-11 Derek Xu Update vm_service constraints to >=6.0.0 <11.0.0 (#1842) webdev (https://github.com/dart-lang/webdev/compare/094ee97..f978b90): f978b90 2023-01-13 Elliott Brooks (she/her) [MV3] Debug session persists across closing and opening Chrome DevTools (#1894) b1b4eff 2023-01-13 Anna Gringauze Prepare for dart 3.0 alpha changes: generate assets (#1887) 969f41f 2023-01-13 Elliott Brooks (she/her) Save encoded URI for ACX DevTools (#1890) 8384a11 2023-01-13 Elliott Brooks (she/her) Skip flaky test on windows (#1893) 8224045 2023-01-13 Elliott Brooks (she/her) Ignore `illegal_language_version_override` for non null-safe fixtures (#1891) e42a030 2023-01-13 Elliott Brooks (she/her) Re-enable most test cases in `devtools_test` (#1881) e134e5b 2023-01-11 Elliott Brooks (she/her) [MV3] Dart debug extension supports DWDS versions < `17.0.0` (#1882) ed80c94 2023-01-11 Elliott Brooks (she/her) [MV3] Prepare extension for release (#1886) be616cd 2023-01-10 Anna Gringauze Return error from expression evaluation if the evaluator is closed. (#1884) 18b3277 2023-01-10 Elliott Brooks (she/her) [MV3] Fix late initialization error on debugger detach (#1879) 03d4035 2023-01-10 Elliott Brooks (she/her) Check if storage object exists before trying to read properties(#1883) ae55fec 2023-01-10 Elliott Brooks (she/her) Format manifest.json (#1885) 3743293 2023-01-10 Anna Gringauze Fix race condition on simultaneous hot restarts (#1870) Change-Id: I2bddd015f1e054eb9e24afb247f9c470257560a9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279073 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Needs investigation.
The text was updated successfully, but these errors were encountered: