Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dart: prefix for unittest library #3431

Closed
sethladd opened this issue Jun 7, 2012 · 9 comments
Closed

Add dart: prefix for unittest library #3431

sethladd opened this issue Jun 7, 2012 · 9 comments
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-not-planned Closed as we don't intend to take action on the reported issue

Comments

@sethladd
Copy link
Contributor

sethladd commented Jun 7, 2012

The unittest library should be accessible via dart: prefix. This will be a heavily used library by external developers who are sharing code, and thus the current solution of absolute paths isn't sufficient.
@iposva-google
Copy link
Contributor

I suggest that this library is being added using pub instead of dart:, overall we should carefully weigh which libraries are elevated to dart: level and which are packages that we supply.

cc @kasperl.

@sethladd
Copy link
Contributor Author

sethladd commented Jun 7, 2012

What's the bar for getting into the dart: club? I'd love to see one syntax so we don't have to weigh the pros and cons of how we import different individual libraries.

@sethladd
Copy link
Contributor Author

For the record, see https://groups.google.com/a/dartlang.org/forum/#!topic/misc/X8qDr24yzXM for public discussion.

@sethladd
Copy link
Contributor Author

Related to bug 3702

@DartBot
Copy link

DartBot commented Aug 18, 2012

This comment was originally written by future...@gmail.com

Unit testing is really important. Since the language is changing, building anything non-trivial on top of Dart like a reusable framework requires continuous confidence that the framework is in-sync with the language, and unit tests help us figure that out. Pub is still green, and is itself changing. Forcing third-party framework vendors to use a sketchy tool to get to the the unit test library does nothing more than encourage us to move on to another language.

@sethladd
Copy link
Contributor Author

The unittest library will be available via pub. The unittest library is shipping in the SDK today, under the pkgs directory. With pub, you should be able to include it with:

dependencies:
  unittest:
    sdk: unittest

Added WontFix label.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Added Pkg-Unittest label.

@kevmoo
Copy link
Member

kevmoo commented Feb 12, 2014

Removed Area-UnitTest label.
Added Area-Pkg label.

@sethladd sethladd added Type-Defect area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. labels Feb 12, 2014
@DartBot DartBot mentioned this issue Jun 5, 2015
Closed
@DartBot
Copy link

DartBot commented Jun 5, 2015

This issue has been moved to dart-lang/test#135.

@kevmoo kevmoo added closed-not-planned Closed as we don't intend to take action on the reported issue and removed resolution-wont_fix labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 7, 2023
@jcollins-g
[deps] rev dartdoc, lints, native, webdev
80a9e51 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/0c8feac..449478c):
  449478c7  Tue Jun 6 20:04:19 2023 -0700  Sam Rawlins  Search: specify package rank in generation; distinguish non-core Dart libs (#3427)
  81af1bf3  Tue Jun 6 17:31:02 2023 -0700  Janice Collins  Prepare for dartdoc 6.3.0. (#3430)
  2b7340d3  Tue Jun 6 17:30:40 2023 -0700  Sam Rawlins  Explicitly export Kind; for internal customer (#3431)
  896540c0  Mon Jun 5 19:39:10 2023 +0000  dependabot[bot]  Bump github/codeql-action from 2.3.5 to 2.3.6 (#3429)

lints (https://github.com/dart-lang/lints/compare/fc74ce0..4b79906):
  4b79906  Tue Jun 6 15:15:22 2023 -0500  Parker Lougheed  Link to 'dart fix' docs in table header (#132)
  b7766d6  Tue Jun 6 09:05:20 2023 -0700  Devon Carew  add 'has quick-fix' checkboxes to the package's readme (#131)

native (https://github.com/dart-lang/native/compare/c851e69..973f3ed):
  973f3ed  Tue Jun 6 10:26:58 2023 +0000  Daco Harkes  [native_assets_cli] Add `dry_run` option (#59)

webdev (https://github.com/dart-lang/webdev/compare/b10d62b..3d7f546):
  3d7f546f  Mon Jun 5 16:24:16 2023 -0700  Elliott Brooks  Add Webdev installation test (#1935)
  9297c663  Mon Jun 5 14:31:43 2023 -0700  Elliott Brooks  Remove unnecessary `async` keywords(#2130)
  6b112b06  Mon Jun 5 12:45:34 2023 -0700  Elliott Brooks  Run DCM workflow against PR branch (#2131)

Change-Id: I6728516c13c1d45f8bbd65c266076c6028ed45ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/307962
Reviewed-by: Devon Carew <devoncarew@google.com>
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-pkg Used for miscellaneous pkg/ packages not associated with specific area- teams. closed-not-planned Closed as we don't intend to take action on the reported issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sethladd @kevmoo @iposva-google @DartBot