Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test.py should not crash if an invalid URL is requested of a test server #34347

Open
whesse opened this Issue Sep 3, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@whesse
Copy link
Member

commented Sep 3, 2018

Unsupported operation: Illegal character in path:
#5 TestingServers._startHttpServer..fileHandler (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:232:9)
#6 DispatchingServer._dispatchRequest (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:35:26)

@whesse whesse self-assigned this Sep 3, 2018

@whesse

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2018

Unhandled exception:
Unsupported operation: Illegal character in path:
#5 TestingServers._startHttpServer..fileHandler (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:232:9)
#6 DispatchingServer._dispatchRequest (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:35:26)

@whesse

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2018

Unhandled exception:
''''
Unsupported operation: Illegal character in path:
#5 TestingServers._startHttpServer..fileHandler (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:232:9)
#6 DispatchingServer._dispatchRequest (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:35:26)
''''

@whesse

This comment has been minimized.

Copy link
Member Author

commented Sep 3, 2018

Unhandled exception:

Unsupported operation: Illegal character in path: <!DOCTYPE 
""""
    #0      _Uri._checkWindowsPathReservedCharacters (dart:core/uri.dart:1714:11)
    #1      _Uri._toWindowsFilePath (dart:core/uri.dart:2643:7)
#2      _Uri.toFilePath (dart:core/uri.dart:2618:22)
#3      new File.fromUri (dart:io/file.dart:264:49)
#4      TestingServers._handleFileOrDirectoryRequest (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:251:22)
<asynchronous suspension>
#5      TestingServers._startHttpServer.<anonymous closure>.fileHandler (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:232:9)
#6      DispatchingServer._dispatchRequest (file:///C:/b/s/w/ir/tools/testing/dart/http_server.dart:35:26)

dart-bot pushed a commit that referenced this issue Sep 4, 2018

Do not crash testing scripts if a test requests a bad URI
Bug: #34347
Change-Id: I505479fcb224332a79dc7e77eab723316d18b3f3
Reviewed-on: https://dart-review.googlesource.com/72684
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.