Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in IOSink.add #35635

Closed
lexaknyazev opened this issue Jan 11, 2019 · 1 comment
Closed

Crash in IOSink.add #35635

lexaknyazev opened this issue Jan 11, 2019 · 1 comment
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@lexaknyazev
Copy link
Contributor

lexaknyazev commented Jan 11, 2019

Dart VM version: 2.2.0-dev.1.1 (Thu Dec 13 12:40:26 2018 +0100) on "windows_x64"
import 'dart:io';
import 'dart:typed_data';

void main() {
  final data = Uint8List(1024 * 1024 * 1024);
  File('tmp.bin').openWrite()..add(data)..close();
}
===== CRASH =====
version=2.2.0-dev.1.1 (Thu Dec 13 12:40:26 2018 +0100) on "windows_x64"
ExceptionCode=-1073741819, ExceptionFlags=0, ExceptionAddress=00007FF66ADD0607
thread=12552, isolate=(null)(0000000000000000)
Stack dump aborted because InitialRegisterCheck failed.

Crash doesn't happen when data is less than 1GB.

@lexaknyazev
Copy link
Contributor Author

Crash happens on linux as well:

tcmalloc: large alloc 1073750016 bytes == 0x561f814c0000 @  0x561f7e2e7632 0x561f7e346585 0x561f7e2e5ecd 0x561f7e344169 0x561f7e347143 0x561f7e141a9b 0x7fd0ed7410b9 0x7fd0eba2852b 0x7fd0eba28474 0x7fd0eba3365e 0x7fd0e6e13e31 0x7fd0e6e12a34 0x7fd0e6e114f4 0x7fd0e6e110f4 0x7fd0e6e10dfc 0x7fd0e6e10a9a 0x7fd0e6e10776 0x7fd0e6e10496 0x7fd0e6e020e9 0x7fd0e6e01c9f 0x7fd0e6e01b77 0x7fd0eba3f090 0x7fd0eba28a7f 0x7fd0ed7413a30x561f7e1bc2a8 0x561f7e1bf719 0x561f7e1eed2e 0x561f7e220a4e 0x561f7e221096 0x561f7e366067 0x561f7e365ef3

===== CRASH =====
version=2.2.0-dev.1.1 (Unknown timestamp) on "linux_x64"
si_signo=Segmentation fault(11), si_code=1, si_addr=(nil)
thread=15293, isolate=(null)((nil))
  [0x0000561f7e1b98a1] dart::ApiMessageReader::ReadInternalVMObject(long, long)
  [0x0000561f7e1b98a1] dart::ApiMessageReader::ReadInternalVMObject(long, long)
  [0x0000561f7e1b7d68] dart::ApiMessageReader::ReadInlinedObject(long)
  [0x0000561f7e1b6a92] dart::ApiMessageReader::ReadMessage()
  [0x0000561f7e2233f3] dart::NativeMessageHandler::HandleMessage(dart::Message*)
  [0x0000561f7e220a4e] dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)
  [0x0000561f7e221096] dart::MessageHandler::TaskCallback()
  [0x0000561f7e366067] dart::ThreadPool::Worker::Loop()
  [0x0000561f7e365ef3] dart::ThreadPool::Worker::Main(unsigned long)
  [0x0000561f7e2c8f89] Unknown symbol
-- End of DumpStackTrace
Aborted (core dumped)

@rmacnak-google rmacnak-google self-assigned this Jan 11, 2019
@dgrove dgrove added the area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. label Jan 12, 2019
dart-bot pushed a commit that referenced this issue Jan 16, 2019
Bug: #35635
Change-Id: I942f2c98c300d72e4b36329ab2e2d0d51029f478
Reviewed-on: https://dart-review.googlesource.com/c/89168
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
dart-bot pushed a commit that referenced this issue Jan 16, 2019
This reverts commit 4b22195.

Reason for revert: 32-bit fails the wrong way

Original change's description:
> [vm, isolate] Fix length truncation in message snapshots.
> 
> Bug: #35635
> Change-Id: I942f2c98c300d72e4b36329ab2e2d0d51029f478
> Reviewed-on: https://dart-review.googlesource.com/c/89168
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com

Change-Id: I47018f43df33a47a08fc4d40a15727ce049393ff
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: #35635
Reviewed-on: https://dart-review.googlesource.com/c/89940
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
dart-bot pushed a commit that referenced this issue Jan 23, 2019
Only run test on x64 VMs.

Bug: #35635
Change-Id: I3ab16a96669a9f29187954896e59a3341dce5dc4
Reviewed-on: https://dart-review.googlesource.com/c/89925
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants