Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block->block_id() <= max_block_id violations #35789

Closed
aartbik opened this issue Jan 28, 2019 · 2 comments
Closed

block->block_id() <= max_block_id violations #35789

aartbik opened this issue Jan 28, 2019 · 2 comments
Assignees
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.

Comments

@aartbik
Copy link
Contributor

aartbik commented Jan 28, 2019

The new graph checker fails as

../../runtime/vm/compiler/backend/flow_graph_checker.cc: 67: error: expected: block->block_id() <= max_block_id

for a larger number of tests in vm-dartkb-linux-debug-x64.

For now, I just disabled the test. But investigate why this happens and who is right.

@aartbik aartbik added the area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends. label Jan 28, 2019
@aartbik aartbik self-assigned this Jan 28, 2019
@aartbik
Copy link
Contributor Author

aartbik commented Jan 28, 2019

For example:

python tools/test.py -n dartkb-mixed-linux-debug-x64 language_2/vm/mult_int_test

--- Command "vm" (took 699ms):
DART_CONFIGURATION=DebugX64 out/DebugX64/dart --no_background_compilation --optimization_counter_threshold=10 --enable_interpreter --ignore-unrecognized-flags --packages=/b/s/w/ir/.packages /b/s/w/ir/out/DebugX64/generated_compilations/dartkb/tests_language_2_vm_mult_int_test/out.dill

exit code:
-6

stderr:
../../runtime/vm/compiler/backend/flow_graph_checker.cc: 67: error: expected: block->block_id() <= max_block_id

dart-bot pushed a commit that referenced this issue Jan 28, 2019
#35789

Change-Id: Id37ca8191eb78431bb9bfaf23dd982b4cc5b44df
Reviewed-on: https://dart-review.googlesource.com/c/91421
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
@aartbik
Copy link
Contributor Author

aartbik commented Jan 28, 2019

@alexmarkov @crelier I can't reproduce this locally at all; since this is rather interpreter-heavy, any pointers on how to debug this (note that one needs to revert the workaround mentioned above).

@alexmarkov alexmarkov assigned alexmarkov and unassigned aartbik Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, FFI, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

2 participants