-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulty building dartdevc outside of SDK. #35834
Comments
Actually, there is a second issue when we disable
|
Confirmed that changing to --libraries /Users/jonahwilliams/Documents/engine/src/third_party/dart/sdk/lib/libraries.json That particular action passes |
Do you know if DDC still has a separate |
I thought they were merged together already - but I really don't know anything about the sdk builds. |
Might be a bit more to this than just the build rules, since eventually we'll need to include a dart:ui library as well. With dart2js it was as easy as passing a |
The second error can be fixed by updating the libraries path in the
I haven't figured out the issue with the bazel_worker package. |
The error in the dartdevc rule occurs when running the training dart action. Something about the paths there is not configured correctly to run in other repos. I can get it to succeed by invoking the same dart command from //third_party/dart/, or by removing all training args |
@jonahwilliams If you add a |
It works! |
@jonahwilliams - is this working well enough to close? We'll be moving to kernel by default soon. |
The flutter engine needs to switch to the full SDK to include web support. As written, the dartdevc rules do not work outside of the sdk repo Bug: #35834 Change-Id: I3b7711cf1920d86b82ddc4f0959b447207f54751 Reviewed-on: https://dart-review.googlesource.com/c/93760 Reviewed-by: Vijay Menon <vsm@google.com> Reviewed-by: Jenny Messerly <jmesserly@google.com> Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Vijay Menon <vsm@google.com>
Resolved in /dart-lang/sdk/commit/3e304def65677c7b62d43e0a7808fedb9e83a281 |
Current Dart SDK revision is: 71bee8f
When attempting to build either the full dart sdk or when adding a dep on dartdevc to the flutter engine BUILD.gn, the build fails on the
//third_party/dart/utils/dartdevc:dartdevc(host)
rule. It cannot find the bazel_worker package, however this package is correctly located in our checkout. Interestingly changing the bazel_worker entry inthird_party/dart/.packages
to a bogus location causes a separate missing file error.To reproduce: checkout flutter/engine according to the instructions at https://github.com/flutter/flutter/wiki/Setting-up-the-Engine-development-environment
Under the
//third_party/dart:create_sdk dep in https://github.com/flutter/engine/blob/master/BUILD.gn#L25, add a dependency on
//third_party/dart:dartdevc`:You can then either run the command from the error message or build the engine host itself.
./flutter/tools/gn --unopt
ninja -C out/host_debug_unopt
A similar error message is thrown if we attempt to set the
dart_platform_sdk
gn arg to false. This can be done by updatingflutter/tools/gn
:cc @vsmenon
The text was updated successfully, but these errors were encountered: