Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context click > Run action not running correct file #3586

Closed
jwren opened this issue Jun 12, 2012 · 3 comments
Closed

Context click > Run action not running correct file #3586

jwren opened this issue Jun 12, 2012 · 3 comments
Assignees
@keertip
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Milestone
IO2012

Comments

@jwren
Copy link
Member

jwren commented Jun 12, 2012

With the sample being for the CodeLab for Google I/O, we have multiple directories with the same sample, each at a different coding step. Each of the directories has the class chat-client.dart, running one chat-client.dart works fine, but if the user goes to a different chat-client.dart and calls Run (either via a context click, or the run button), the previously run chat-client.dart is run, not the one selected by the user.
@jwren
Copy link
Member Author

jwren commented Jun 12, 2012

Removed this from the M1 milestone.
Added this to the IO2012 milestone.

@devoncarew
Copy link
Member

On further investigation, this is just with Dartium launches. It has to do with having n html files in a project, all referencing n dart files, all with the same name. An html file - which should just have a reference to one dart file - instead thinks it has a reference to all the dart libraries in the project.

Set owner to @keertip.

@keertip
Copy link
Contributor

keertip commented Jun 15, 2012

http://codereview.chromium.org/10563005/

Added Fixed label.

@jwren jwren added Type-Defect P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jun 15, 2012
@jwren jwren added this to the IO2012 milestone Jun 15, 2012
copybara-service bot pushed a commit that referenced this issue Oct 18, 2022
@sigurdm
Bump pub to 817e61d9eb174f77dfd2cb1d1de45826f66ac6bf
250db68 
Changes:
```
> git log --format="%C(auto) %h %s" 28a2503..817e61d
 https://dart.googlesource.com/pub.git/+/817e61d9 Fix publishing (#3610)
 https://dart.googlesource.com/pub.git/+/97f638d0 PubToplevel.directory is never null. (#3587)
 https://dart.googlesource.com/pub.git/+/a3ee2099 Make binstubs offset invariant (#3586)
 https://dart.googlesource.com/pub.git/+/67e44b4b Make >=2.12 <3.0.0 compatible with dart 3 (#3572)
 https://dart.googlesource.com/pub.git/+/c287c110 Warn on `pub publish` if `dart analyze` has messages (#3568)
 https://dart.googlesource.com/pub.git/+/29d7d868 Cleaner pubspec.lock parsing (#3487)

```

Diff: https://dart.googlesource.com/pub.git/+/28a2503d7f4806e6854e3ed0d783f065abfd1b5f~..817e61d9eb174f77dfd2cb1d1de45826f66ac6bf/
Change-Id: I203963479a2bb78db80d8e645066a227febeef46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264680
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keertip keertip

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures
Projects
None yet
Milestone
IO2012
Development

No branches or pull requests
3 participants
@devoncarew @jwren @keertip